[SYCL] Fix build after 1db2a088d8fd#22674
Open
wenju-he wants to merge 1 commit into
Open
Conversation
The new fp4 extension unittest added by 1db2a088d8fd ([SYCL] Implement sycl_ext_oneapi_fp4 extension) includes float_4bit/types.hpp, which pulls in <sycl/marray.hpp> and thereby <sycl/detail/common.hpp>. That translation unit never instantiates the static function template convertToArrayOfN, so under -Werror,-Wunused-template (enabled by 1529d35) the build fails: include/sycl/detail/common.hpp:60:18: error: unused function template 'convertToArrayOfN' [-Werror,-Wunused-template] Remove the internal-linkage 'static' specifier from the template. This gives it external linkage, which suppresses -Wunused-template for a never-instantiated template (mirroring the fix in PR intel#22583 for other SYCL header templates) while keeping the existing callers in image.hpp and accessor_image.hpp working. Fixes: CMPLRLLVM-76994 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new fp4 extension unittest added by 1db2a088d8fd ([SYCL] Implement sycl_ext_oneapi_fp4 extension) includes float_4bit/types.hpp, which pulls in <sycl/marray.hpp> and thereby <sycl/detail/common.hpp>. That translation unit never instantiates the static function template convertToArrayOfN, so under -Werror,-Wunused-template (enabled by 1529d35) the build fails:
include/sycl/detail/common.hpp:60:18: error: unused function template
'convertToArrayOfN' [-Werror,-Wunused-template]
Remove the internal-linkage 'static' specifier from the template. This gives it external linkage, which suppresses -Wunused-template for a never-instantiated template (mirroring the fix in PR #22583 for other SYCL header templates) while keeping the existing callers in image.hpp and accessor_image.hpp working.
Fixes: CMPLRLLVM-76994