[SYCL] Reusable events extension implementation#22399
Merged
Merged
Conversation
for the barrier (handler-less).
pass reusable event by const reference.
submit of signal event, host task unit test.
Remove a check for number of devices in the context from make_event.
YuriPlyakhin
approved these changes
Jul 10, 2026
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
Contributor
There was a problem hiding this comment.
llvm/include/llvm/SYCLLowerIR/DeviceConfigFile.td LGTM
againull
approved these changes
Jul 13, 2026
againull
reviewed
Jul 13, 2026
againull
left a comment
againull
left a comment
Contributor
There was a problem hiding this comment.
Please consider defining feature macro in feature_test.hpp.in.
Contributor
Author
|
@mmichel11 @intel/sycl-graphs-reviewers @uditagarwal97 @intel/unified-runtime-reviewers-level-zero could you please review? Thank you! |
the failure is not related to any changes in this PR. A similar test was prepared, but without any use of reusable events APIs, and was placed in the same file (the same UR mock replaced callbacks) and it also failed. The issue is most probably related to how the host task threads work with UR mock functions. The issue will be addressed in a separate PR and then the test related to a host task will be added to reusable events unit tests.
mmichel11
approved these changes
Jul 13, 2026
mmichel11
left a comment
mmichel11
left a comment
Contributor
There was a problem hiding this comment.
Graph changes LGTM. Just a comment regarding support for this feature with SYCL graph native recording.
Contributor
|
FAIL: SYCL :: Adapters/level_zero/device_scope_events.cpp |
Contributor
Author
|
@intel/llvm-gatekeepers please consider merging |
Contributor
Author
|
@againull thanks for helping to address the review comments! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of the sycl_ext_oneapi_reusable_events extension.
Assisted-By: Claude