ci: add a Windows smoke test job

[napetrov]

Builds and installs the wheel on windows-latest, runs the installed-package smoke test and a few fast unit tests (CLI help, console encoding).

Claude-Session: https://claude.ai/code/session_014c5XskkF73QCnmajmCAq8j

Summary

Adds a windows-smoke job to ci.yml on windows-latest. It’s a basic check that dokimi works on Windows, not full validation: it builds and installs the wheel, runs scripts/smoke_installed.py against the installed package, and runs a few fast unit tests (test_cli_help.py, test_console_encoding.py). It uses a GitHub-hosted runner because the Intel pool has no Windows runners. No changelog fragment is needed because the change touches CI only.

Changes

Risk

Testing

Checklist

• Tests added/updated and pytest passes
• ruff, mypy, and schema checks pass
• Docs updated (or N/A) — see the docs-drift checklist in CONTRIBUTING.md
• No ad-hoc run artifacts committed
• New files carry the SPDX license header (or are exempt in .github/.licenserc.yaml)

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.27%. Comparing base (f76a760) to head (700eee5).
⚠️ Report is 4 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   90.26%   90.27%   +0.01%     
==========================================
  Files         206      206              
  Lines       24289    24347      +58     
  Branches     3906     3921      +15     
==========================================
+ Hits        21924    21980      +56     
- Misses       1700     1702       +2     
  Partials      665      665              

see 12 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

🟡 Changes recommended

The new job needs local-CI integration to prevent its wheel-install argument from breaking make dev.

1 open issue

• Register windows-smoke in local CI job and tool specifications · New

What changed in this PR

Adds a lightweight Windows compatibility check for the packaged application without running the full test suite.

Changes:

• Adds a GitHub-hosted Windows job using Python 3.13.
• Builds and installs the wheel, then runs the installed-package smoke test.
• Runs focused CLI help and console encoding tests.

File	Description
.github/​workflows/​ci.yml	Adds the Windows build, installation, and smoke-test job.

_{Review effort: Balanced}

[napetrov]

Fixed in commit 79e1fd9. Added windows-smoke to both ISOLATED and NEEDS_NETWORK in ci_local.py, matching package-smoke treatment to ensure the job runs in an isolated venv when ci_local is executed. Also added regression test test_windows_smoke_is_registered_as_isolated() and test_isolated_job_ids_match_real_jobs() to catch future renames.

[napetrov]

Already in 79e1fd9: windows-smoke is in both ISOLATED and NEEDS_NETWORK. Checked on the branch; no further change.

[Copilot]

🟢 Approval recommended

No unresolved findings remain, and the previous local-runner integration issue is fixed with regression coverage.

1 open issue

• Register windows-smoke in local CI job and tool specifications

_{Review effort: Balanced}

[antonwolfy]

Review at 79e1fd9. The job and the ci_local.py registration are right: windows-smoke is now isolated like package-smoke, and tool_specs() no longer returns the literal wheel glob. The regression test does not guard that property, and the docs around the job are now stale. Inline comments cover both.

What I ran, on a Linux review host at 79e1fd9:

• make ci-local: 23 passed, 0 failed, 4 skipped (docker, test-latest, docs.yml:deploy, semgrep). 5181 tests passed, 1 skipped. The windows-smoke steps ran in the isolated venv and passed.
• zizmor on the workflows: no findings.
• Mutation check on ci_local.py: dropping windows-smoke from only ISOLATED, or from only NEEDS_NETWORK, fails test_windows_smoke_is_registered_as_isolated (1 failed, 17 passed). test_isolated_job_ids_match_real_jobs stays green in both runs.

Checked, no issues

• Pins and permissions: the action SHAs match package-smoke, persist-credentials: false is set, and the workflow-level permissions and concurrency apply.
• Changelog: the PR touches only .github/, scripts/ and tests/, so no fragment is needed.
• Windows steps: I could not run them. By reading, smoke_installed.py is portable (pathlib, explicit UTF-8), and the lock file carries the colorama and tzdata Windows markers.

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

5 open issues

• Because the job-wide working-directory is dokimi, the pytest invocation will run from inside… · New
• Because the job-wide working-directory is dokimi, the pytest invocation will run from inside… · New
• This assertion is overly broad: tool_specs() aggregates pip args across workflows, and * (and,… · New
• Register windows-smoke in local CI job and tool specifications
• Use python -m pip install ... consistently instead of invoking pip directly. This avoids edge… · New

_{Review effort: Lite}

[Copilot]

🟢 Approval recommended

The focused CI changes address prior feedback and have no identified blocking issues, though Windows execution remains unverified.

1 open issue

• Register windows-smoke in local CI job and tool specifications

4 resolved since last review

• This assertion is overly broad: tool_specs() aggregates pip args across workflows, and * (and,…
• Because the job-wide working-directory is dokimi, the pytest invocation will run from inside…
• Because the job-wide working-directory is dokimi, the pytest invocation will run from inside…
• Use python -m pip install ... consistently instead of invoking pip directly. This avoids edge…

_{Review effort: Balanced}

[antonwolfy]

Review at 91f269b. The ci.yml header comment is fixed and the regression test now looks at tool_specs() output. One of the new changes does not do what its commit says: the pytest step still imports dokimi from the checkout.

What I ran, on a Linux review host at 91f269b:

• make ci-local: 23 passed, 0 failed, 4 skipped (docker, test-latest, docs.yml:deploy, semgrep). The windows-smoke steps ran in the isolated venv.
• Mutation runs on test_ci_local.py: removing windows-smoke from ISOLATED only fails test_windows_smoke_is_registered_as_isolated. Removing it from NEEDS_NETWORK only leaves all 18 tests green.
• A probe test run from a clean directory with the same pytest arguments, with the Windows runner itself not run. It shows the checkout is on sys.path, see the inline comment.

Still open from my earlier review:

• dokimi/docs/architecture.md:346 (outside this diff): the ci.yml job list still stops at package-smoke, with no windows-smoke.
• dokimi/scripts/ci_local.py:19 (outside this diff): the docstring still says the jobs that install the package are "(package-smoke)", while ISOLATED now holds two.
• dokimi/tests/test_ci_local.py:344 (outside this diff): test_isolated_job_ids_match_real_jobs still accepts any pip install substring, so pip install -r x satisfies it.

Checked, no issues

• Local runner: windows-smoke is in both ISOLATED and NEEDS_NETWORK. With the registration removed from ISOLATED, the test fails and shows $RUNNER_TEMP/dist/*.whl in the specs.
• pytest config from another cwd: with absolute file arguments, pytest still picks dokimi/pyproject.toml as the ini file, so --allow-hosts, the timeout and the filters apply. Both test files pass (89 passed).
• Lock file: pytest and the plugins are in requirements.lock.txt with no platform markers. colorama and tzdata carry the win32 markers.
• Changelog: the PR touches only .github/, scripts/ and tests/, so no fragment is needed.