Repository navigation
feat(judge-validity): --context stored — gate the judge the way arms are scored #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
656cf2c
feat(arms): keep the judge's treatment material in the artifact
napetrov 6c88dba
feat(judge-validity): --context stored — gate the judge the way arms …
napetrov 41316ba
fix(cross-judge): count only material that hashes to its digest as re…
xaleryb 497a489
fix(utils): digest text holding a lone surrogate instead of raising
xaleryb ec6348f
fix(validity): don't add label suffix, match (judge, context) pairs i…
napetrov 409b5a7
feat(judge-validity): add context field to Measure, filter by materia…
napetrov 1132ad3
fix(judge-validity): use attach_stored_context dropped count, not pre…
napetrov 22a9079
test(judge): add tests killing 4 surviving mutants
napetrov 12dcd71
fix(judge-validity): per-arm counts, arm-dropped refusal, narrow exit…
napetrov eb6b9c9
test(judge-context): pin the missing-material warning wording
napetrov f33b74c
fix(judge-context): keep the 'No stored judge context' warning prefix
napetrov 8d3c1fb
test(judge-validity): expect the 'No stored judge context' warning pr…
napetrov 81725fa
docs(changelog): judge-validity --context stored
napetrov 1210bd3
test: assert exit codes outside the except block (ruff PT017)
napetrov 473b543
fix(judge-validity): pool-aware stopped_by, context-aware stored meas…
claude 40ffb49
fix(cross-judge): a validity FAIL is never overwritten by a PASS
napetrov 127a2db
Merge origin/main (#69 merged) into validity-context
napetrov 4be8e81
docs(judge-validity): list every exit-2 case; fix stale snippet wording
napetrov a5bf513
Merge remote-tracking branch 'origin/main' into validity-context
napetrov 6f5f2a1
fix(judge-validity): refuse an unsampled stored arm; mixed stored mea…
napetrov 4f76ba6
fix(judge-validity): report bases scored in sequential mode; drop dea…
napetrov 2ce39b1
Merge origin/main into validity-context
napetrov e2b0127
fix(judge-validity): address code-review threads on PR #73
napetrov ccf04a1
chore: untrack uv.lock added by mistake
napetrov cc617ab
fix(judge-validity): derive measure context per answer, refuse starve…
napetrov fbb7017
refactor(judge-validity): return Built(pairs, n_dropped) from _build
napetrov a3ba73b
fix(judge-validity): refuse an unpaired stored arm in sequential mode…
xaleryb 3aacf7c
test, fix(judge-validity): pin the context label of a measure with no…
napetrov 50174e3
Merge main into validity-context
napetrov af67719
Merge main into validity-context
napetrov d441c7a
fix(judge): refuse a stored --sequential run that left an arm with 0 …
napetrov 1c4d0c6
fix(judge-validity): report a sequential FAIL even when an arm went u…
xaleryb b5b420b
fix(judge-validity): name a remedy that works for a sequentially unsc…
xaleryb 2344f45
docs(judge-validity): list the unscored sequential arm exit in --cont…
antonwolfy 02d7397
fix(judge-validity): tell a sequential arm refusal to raise --bases too
antonwolfy be965f2
fix(judge-sequential): count an arm as scored only by a graded pair
napetrov 3ea012a
fix(judge-validity): refuse a stored arm whose only pairs are padding
xaleryb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
dokimi/changelog.d/20261016_000000_judge_validity_stored_context.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| ### Added | ||
|
|
||
| - **`eval judge-validity --context stored`** — judges each base with the arms | ||
| artifact's verified `judge_materials`, the same material the arms were scored | ||
| with. Bases without verified material are dropped before `--bases` / | ||
| `--max-bases` sampling; the summary reports `n_without_context` and per-arm | ||
| kept/dropped counts in `by_arm` (with `scored` bases in `--sequential` mode). The run exits 2 with a typed scorer or | ||
| `--mode pairwise`, on a file with no non-empty verified material, if an arm | ||
| loses all its bases, has only `padding` pairs or gets none sampled, if a `--sequential` run would pass | ||
| with none of an arm's bases scored, or if no pair is usable. | ||
|
|
||
| ### Changed | ||
|
|
||
| - **`eval judge-validity` exits 2 when no pair is usable, in every mode** — a | ||
| file with no answer longer than the minimum (or where every degradation is a | ||
| no-op) now prints an `Error:` line and exits 2 instead of a `ValueError` | ||
| traceback (exit 1), with or without `--context`. | ||
|
|
||
| - **`cross-judge --validity` matches a PASS by judge and context** — a passing | ||
| report validates a measure only when both the judge label and the context | ||
| (`stored` or `none`) agree, so a no-context PASS no longer validates a judge | ||
| that read the stored material. A FAIL still silences every measure of that | ||
| judge in any context, and a PASS never lifts it, whatever the report | ||
| order. Reports without a `context` key (written before this | ||
| change) count as `none`, and a stored measure whose scores fell back to | ||
| snippets is `none` too; one mixing stored and snippet scores is `mixed`, | ||
| which no PASS validates. `cross-judge --judges` re-scores with the | ||
| stored material. |
7 changes: 7 additions & 0 deletions
7
dokimi/changelog.d/20261021_000000_napetrov_sequential-unscored-arm.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| ### Changed | ||
|
|
||
| - **`eval judge-validity --context stored --sequential` exits 2 when an arm with | ||
| verified material got no scored base** — the SPRT can decide on the other arms | ||
| and stop first; the run now refuses, as fixed mode does, instead of passing | ||
| without covering that arm. A FAIL on the bases that were scored is still | ||
| reported as a FAIL (exit 1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.