Repository navigation
docs(prepare-repo): the checklist puts review rules in the prompt; say what E1 and E2 cannot separate - #196
Conversation
…y what E1 and E2 cannot separate Leftovers from the review of intel#65: - The checklist still said to keep review rules in the review section of AGENTS.md, while §6 says to place them in the prompt, the only placement measured on seeded defects. - §1 now gives both steps of E1: installing the pinned formatter (5 to 7 of 16, p = 0.5) and then naming it (7 to 12, p = 0.062). Neither is separated from noise at 16 cells. - §8 and the E2 row say the build-break counts are pooled over the 3 renames with no per-task count stored, and that the 4/9 to 6/9 pass rate is p = 0.5 even in the best case. Signed-off-by: Anton Volkov <antonwolfy@gmail.com>
|
@exai-bot /review |
exai-bot
left a comment
There was a problem hiding this comment.
Note
AI-generated review of 29faac58920b, requested by @vchamarthi, using the default review skill. It can be wrong: verify a finding before acting on it. React with a thumbs up or down on a finding to tell the bot whether it helped.
Model us.anthropic.claude-sonnet-5-5, effort default, 3 of 80 turns, 0.2 of 40 minutes, 36k in / 961 out tokens.
Docs-only change that fixes the checklist line to point at the review prompt (§6), consistent with §6's "place them in the prompt for now". It also adds the pooled-count and p = 0.5 caveats to the E2 text, and splits the E1 comparison into its install and naming steps. I checked the quoted sign-test p-values (2 up 0 down gives 0.5, 5 up 0 down gives 0.0625, 7 up 0 down gives 0.016), and they match the E1 evidence row. I found no defects.
No issues found.
vchamarthi
left a comment
There was a problem hiding this comment.
No blockers CI at the head is not green (0 failing, 15 pending).
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
==========================================
- Coverage 91.78% 91.77% -0.02%
==========================================
Files 223 223
Lines 27623 27623
Branches 4549 4549
==========================================
- Hits 25354 25350 -4
- Misses 1606 1609 +3
- Partials 663 664 +1 🚀 New features to boost your workflow:
|
napetrov
left a comment
There was a problem hiding this comment.
Checklist now matches §6 and the E1/E2 claims are stated at their real strength. LGTM.
Summary
Three points from the review of #65 that were still open when it merged. Two are risks: the checklist contradicts §6, and the E2 figures read as stronger than their counts. One is a nit: the E1 comparison I asked for is missing. Only docs change.
Changes
AGENTS.mdplacement was not tested on seeded defects. The checklist still said "in the review section ofAGENTS.md". It now says the prompt (§6), and thatAGENTS.mdplacement is not measured yet.Risk
None to behaviour: two doc pages.
Testing
On a Linux review host, at
7b425a5(onmain506f7ba):make ci-local: 29 passed, 0 failed, 7 skipped (the Docker catalog smoke,test-latest, thecli-surfacepackaging step, conda-forge-deps without micromamba, docsdeploy, the pip-audit report, semgrep). 7,381 tests passed, 1 skipped.main92d92d3 (test(llm): pin provider-call budgets for judge, panel, answer and validation paths #170, tests only) before opening; with the ten follow-up branches merged together, the full suite (7,447 passed, 1 skipped), the growth check,mypyandruffpass.Checklist
pytestpassesruff,mypy, and schema checks pass.github/.licenserc.yaml)