Repository navigation
fix(repo): tasks check --warm judges task host requirements - #182
Merged
Merged
Conversation
napetrov
requested review from
antonwolfy,
jharlow-intel,
vchamarthi and
xaleryb
as code owners
October 22, 2026 10:50
--warm skipped the host verdict, so on a host that misses a task's requirements the untouched-tree null run passed and the task was reported broken instead of unsupported; --allow-unsupported could not pass it. The probe sees the same container view (affinity, cgroup quota) with or without network. repo run already judged the host. check_task's null/oracle step moves to _check_step (CC 21 -> 13). Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
+ Coverage 91.64% 91.66% +0.02%
==========================================
Files 222 222
Lines 27409 27410 +1
Branches 4508 4508
==========================================
+ Hits 25118 25126 +8
+ Misses 1620 1615 -5
+ Partials 671 669 -2
🚀 New features to boost your workflow:
|
antonwolfy
reviewed
Oct 22, 2026
antonwolfy
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The fix is right: --warm now judges the host through the same _host_reason path as an offline check, and the _check_step extraction keeps the old behaviour for the null/oracle steps. Two nits inline.
What I ran, on a Linux review host at 9598a29:
make ci-local: 27 passed, 1 failed, 7 skipped. The failure ispip-audit, reporting a new gitpython 3.2.0 advisory (CVE-2026-114145) in the existing locks; it is not caused by the PR. 7089 tests passed; the changed-line coverage gate passed.- Mutation run on
selfcheck.py: 24 mutants against the host/runner/run test files. Every mutant that changes which steps run, including restoringNone if warm, is killed. 8 survive, all in the moved_check_stepfailure paths (see the second inline comment).
Checked, no issues
- Equivalence: the old loop and
_check_stepmatch on prepare failure ("{kind}: {exc}", no verdict problems, other step still runs), on oracle non-zero/timeout, and on the skip condition (not reason/run_oracle). - Probe cost:
run_checkprobes once per check and passeshostto everycheck_task, so--warmadds no probes. - Probe view:
probe_hostruns withnetwork="none"and the evaluation's runner flags, so--warm's network does not change the affinity or cgroup quota view.
Signed-off-by: Anton Volkov <antonwolfy@gmail.com>
Signed-off-by: Anton Volkov <antonwolfy@gmail.com>
Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
Contributor
|
napetrov
added a commit
to napetrov/dokimi
that referenced
this pull request
Oct 23, 2026
main's intel#182 judges the host under --warm in every case, so drop this PR's judge_host wiring and its changelog fragment; the test stays. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
napetrov
added a commit
to napetrov/oneDAL
that referenced
this pull request
Oct 24, 2026
Moves the reusable workflow and the quick-start install from ad1cbd0 to intel/dokimi main 09be35b, which adds the workflow's allow-unsupported input (intel/dokimi#156), judges task host requirements under --warm (intel/dokimi#182) and ships the built-in review graders (intel/dokimi#120). repo validate passes unchanged on 27 tasks. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
napetrov
added a commit
to napetrov/oneDAL
that referenced
this pull request
Oct 24, 2026
…host dokimi now judges task host requirements under --warm (intel/dokimi#182) and the reusable workflow can pass --allow-unsupported (intel/dokimi#156). The task leaves exclude-tasks: on a runner with 4+ GenuineIntel CPUs it is self-checked like every other task; on a smaller or AMD runner dokimi reports it unsupported with the reason instead of a null run that passes, and the job passes. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
napetrov
added a commit
to napetrov/oneDAL
that referenced
this pull request
Oct 26, 2026
Moves the reusable workflow and the quick-start install from ad1cbd0 to intel/dokimi main 09be35b, which adds the workflow's allow-unsupported input (intel/dokimi#156), judges task host requirements under --warm (intel/dokimi#182) and ships the built-in review graders (intel/dokimi#120). repo validate passes unchanged on 27 tasks. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
napetrov
added a commit
to napetrov/oneDAL
that referenced
this pull request
Oct 26, 2026
…host dokimi now judges task host requirements under --warm (intel/dokimi#182) and the reusable workflow can pass --allow-unsupported (intel/dokimi#156). The task leaves exclude-tasks: on a runner with 4+ GenuineIntel CPUs it is self-checked like every other task; on a smaller or AMD runner dokimi reports it unsupported with the reason instead of a null run that passes, and the job passes. Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #41 (D3 follow-up: host requirements under --warm).
Summary
repo runalready judged the host on every path; onlytasks check --warmskipped it. The null/oracle step moves to_check_step(radon CC ofcheck_task21 -> 13).Evidence
tasks check --warmon a host missingmin_cpus: null ran on the untouched tree, task reportedbroken,--allow-unsupportedcould not pass it (test assertedverdict != "unsupported").After:
test_warm_judges_the_host_like_an_offline_check:--warm->unsupported/host, no null, exit 1; with--allow-unsupportedexit 0.pytest -q: 7068 passed, 22 skipped;ruff check .andmypy(CI lock, py3.12) clean.Merge Danger
Door: two-way
Blast Radius: narrow
CI that runs
tasks check --warmon a host missing a task's requirements now seesunsupported(exit 1 unless--allow-unsupported) instead of whatever null/oracle gave.🤖 Generated with Claude Code