Skip to content

fix: add the missing license header to two repos modules - #144

Merged
xaleryb merged 1 commit into
intel:mainfrom
napetrov:fix/license-headers-1021
Oct 21, 2026
Merged

xaleryb merged 1 commit into
intel:mainfrom
napetrov:fix/license-headers-1021

Conversation

@napetrov

Copy link
Copy Markdown
Contributor

Summary

dokimi/repos/errors.py and dokimi/repos/host_spec.py landed in #112 without the Intel copyright / SPDX header. The skywalking-eyes header check in Static checks fails on main and on every open PR that merges main:

ERROR the following files don't have a valid license header:
dokimi/dokimi/repos/errors.py
dokimi/dokimi/repos/host_spec.py

Adds the same two-line header the other modules carry. No code change.

Merge Danger

None. Header comments only.

🤖 Generated with Claude Code

Both files came in with intel#112 without the SPDX header, so the
skywalking-eyes header check in Static checks fails on main and on
every PR that merges main.

Signed-off-by: Nikolay Petrov <nikolay.a.petrov@intel.com>
@napetrov napetrov added the skip-changelog No user-visible change: bypasses the changelog fragment check label Oct 21, 2026
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.30%. Comparing base (61e0355) to head (b391d41).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   91.29%   91.30%           
=======================================
  Files         216      216           
  Lines       26565    26565           
  Branches     4337     4337           
=======================================
+ Hits        24252    24254    +2     
+ Misses       1645     1643    -2     
  Partials      668      668           
Files with missing lines Coverage Δ
dokimi/dokimi/repos/errors.py 100.00% <ø> (ø)
dokimi/dokimi/repos/host_spec.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xaleryb

xaleryb commented Oct 21, 2026

Copy link
Copy Markdown
Contributor
  • Ran: the pinned skywalking-eyes header check with the CI config on main, on the head, and on the head with one SPDX line changed to MIT; plus ruff, mypy strict, bandit -ll and the full pytest suite at the head.
  • Header check: main fails and lists exactly dokimi/repos/errors.py and dokimi/repos/host_spec.py. The head passes. The mutated head fails again, so the gate still catches a broken header.
  • The diff adds only the 2-line Copyright/SPDX header and a blank line to each file. The bytes match dokimi/repos/__init__.py, and there is no code change.
  • ruff, mypy, bandit and pytest give the same results as main. DCO is signed off. skip-changelog fits a header-only change.
  • No open findings. No commits from us. Nothing is left for the author.

@xaleryb xaleryb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved at b391d41. The pinned header check fails on main for these two files, passes on this head, and fails again when an SPDX line is broken; the diff is header-only and CI is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog No user-visible change: bypasses the changelog fragment check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants