Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/cli-node-compatibility.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ concurrency:
jobs:
classify:
name: Classify changed surfaces
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 10
permissions:
contents: read
Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:
route:
name: Select PR check runners
if: ${{ vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
permissions:
contents: read
Expand Down Expand Up @@ -71,7 +71,7 @@ jobs:
# leaves the output empty, which runs the matrix.
if: ${{ !cancelled() && needs.classify.outputs.cli != 'false' }}
# Rootless opt-in (always, or overflow when hosted runners are saturated); approval-based trust, not strict admission control. See docs/ci-runners.md.
runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-latest"]') }}
runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-24.04"]') }}
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -168,7 +168,7 @@ jobs:
name: CLI Node Compatibility Guard
needs: [classify, project-options]
if: ${{ !cancelled() }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ concurrency:
jobs:
analyze:
name: Analyze JavaScript and TypeScript
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 30

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependency-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ concurrency:
jobs:
review:
name: Review dependency changes
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 10

steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/desktop-connect-discovery-guard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concurrency:
jobs:
classify:
name: Classify changed surfaces
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 10
permissions:
contents: read
Expand Down Expand Up @@ -191,7 +191,7 @@ jobs:
name: Packaged Connect Discovery Guard
needs: [classify, packaged-connect-discovery]
if: ${{ !cancelled() }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
permissions:
contents: read
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/desktop-release-guard.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
classify:
name: Classify changed surfaces
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 10
permissions:
contents: read
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
if: >-
${{ !cancelled() && github.event_name != 'push'
&& needs.classify.outputs.desktop != 'false' }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
outputs:
version: ${{ steps.version.outputs.version }}
release_sha: ${{ github.sha }}
Expand Down Expand Up @@ -639,7 +639,7 @@ jobs:
name: Finalize unsigned validation checksums
if: ${{ !cancelled() && github.event_name != 'push' }}
needs: [classify, validation-version, package]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 15
steps:
- name: Resolve desktop packaging applicability
Expand Down Expand Up @@ -710,7 +710,7 @@ jobs:
preflight:
name: Protected read-only trusted release preflight
if: github.event_name == 'push' && github.ref_type == 'tag' && startsWith(github.ref_name, 'desktop-v')
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
environment:
name: desktop-release-preflight
permissions:
Expand Down Expand Up @@ -1099,7 +1099,7 @@ jobs:
name: Revalidate production architectures and finalize checksums
if: needs.preflight.result == 'success'
needs: [preflight, release-package]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 15
steps:
- name: Checkout exact immutable release SHA
Expand Down Expand Up @@ -1142,7 +1142,7 @@ jobs:
name: Sign trusted update metadata
if: needs.preflight.result == 'success'
needs: [preflight, release-finalize]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 15
environment:
name: desktop-release
Expand Down Expand Up @@ -1204,7 +1204,7 @@ jobs:
name: Publish new immutable desktop release
if: needs.preflight.result == 'success'
needs: [preflight, sign]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 15
permissions:
contents: write
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/docker-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ permissions:
jobs:
validate-release:
name: Validate Release
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
# The unsharded full server and UI suites alone exceed an hour on a hosted
# runner (945 units); 60 minutes cancelled the v0.9.0 release mid-suite.
timeout-minutes: 150
Expand Down Expand Up @@ -118,7 +118,7 @@ jobs:
prepare-cli:
name: Build and Smoke Test CLI
needs: validate-release
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 30
permissions:
contents: read
Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:
preflight-cli:
name: Preflight npm Release Artifact
needs: [validate-release, prepare-cli]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 15
permissions:
contents: read
Expand Down Expand Up @@ -340,7 +340,7 @@ jobs:
name: Publish CLI with provenance
if: github.ref_type == 'tag' || github.event_name == 'workflow_dispatch'
needs: [validate-release, prepare-cli, build-smoke-and-push]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 30
permissions:
contents: read
Expand Down Expand Up @@ -395,7 +395,7 @@ jobs:
name: Publish GitHub release
if: github.ref_type == 'tag' || github.event_name == 'workflow_dispatch'
needs: [validate-release, build-smoke-and-push, publish-cli]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 30
permissions:
contents: write
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/hosted-ui-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ permissions:
jobs:
deploy:
name: Deploy ${{ inputs.release_tag }} to app.propr.dev
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 30
# The Cloudflare token lives only in this protected environment, so no
# build, PR or other release job can read it. Its deployment policy allows
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/pr-build-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
# test/ciChangeClassification.test.mjs; nothing in this file restates them.
classify:
name: Classify changed surfaces
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 10
permissions:
contents: read
Expand Down Expand Up @@ -45,7 +45,7 @@ jobs:
route:
name: Select PR check runners
if: ${{ vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
permissions:
contents: read
Expand Down Expand Up @@ -77,7 +77,7 @@ jobs:
# superseded-run cancellation intact.
if: ${{ !cancelled() && needs.classify.outputs.cli != 'false' }}
# Rootless opt-in (always, or overflow when hosted runners are saturated); approval-based trust, not strict admission control. See docs/ci-runners.md.
runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-latest"]') }}
runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-24.04"]') }}
timeout-minutes: 30
permissions:
contents: read
Expand Down Expand Up @@ -204,7 +204,7 @@ jobs:
name: CLI Agent Skill (Linux x64, glibc 2.31, Node 22)
needs: classify
if: ${{ !cancelled() && needs.classify.outputs.cli != 'false' }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
container:
image: node:22.22.3-bullseye-slim@sha256:f81e523790f0a2c86827ff6356a28fad2edbe0fe36bc3c4275a4d1e16304bf43
permissions:
Expand Down Expand Up @@ -446,7 +446,7 @@ jobs:
needs: route
if: ${{ !cancelled() }}
# Rootless opt-in (always, or overflow when hosted runners are saturated); approval-based trust, not strict admission control. See docs/ci-runners.md.
runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-latest"]') }}
runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-24.04"]') }}
env:
ACTIONLINT_IMAGE: rhysd/actionlint@sha256:b1934ee5f1c509618f2508e6eb47ee0d3520686341fec936f3b79331f9315667
permissions:
Expand Down Expand Up @@ -1169,7 +1169,7 @@ jobs:
if: >-
${{ always() && needs.validate.result == 'failure' &&
github.event.pull_request.head.repo.full_name == github.repository }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
permissions:
contents: read
pull-requests: write
Expand Down Expand Up @@ -1229,7 +1229,7 @@ jobs:
- windows-connect-discovery
- connect-authority-darwin
if: ${{ !cancelled() }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
permissions:
contents: read
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
# repo before running PR code on the self-hosted runner. Fail-closed.
authorize:
name: Authorize label actor
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: >-
github.event.action == 'labeled' &&
github.event.label.name == 'preview-env' &&
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/pr-test-on-label.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
classify:
name: Classify changed surfaces
if: ${{ github.event_name == 'pull_request' && !github.event.pull_request.draft }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 10
permissions:
contents: read
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:
route:
name: Select PR check runners
if: ${{ vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 5
permissions:
contents: read
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
needs: route
if: ${{ !cancelled() && (github.event_name == 'workflow_dispatch' || !github.event.pull_request.draft) }}
# Rootless opt-in (always, or overflow when hosted runners are saturated); approval-based trust, not strict admission control. See docs/ci-runners.md.
runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-latest"]') }}
runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-24.04"]') }}
timeout-minutes: 45
permissions:
contents: read
Expand Down Expand Up @@ -306,7 +306,7 @@ jobs:
(github.event_name == 'workflow_dispatch' || !github.event.pull_request.draft) &&
needs.classify.outputs.docs != 'false' }}
# Rootless opt-in (always, or overflow when hosted runners are saturated); approval-based trust, not strict admission control. See docs/ci-runners.md.
runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-latest"]') }}
runs-on: ${{ fromJSON((vars.PROPR_ROOTLESS_PR_CHECKS == 'true' || (vars.PROPR_ROOTLESS_PR_CHECKS == 'overflow' && needs.route.outputs.overflow == 'true')) && github.actor != 'dependabot[bot]' && ((github.event_name == 'pull_request' && github.event.pull_request.user.login != 'dependabot[bot]' && github.event.pull_request.head.repo.full_name == github.repository) || (github.event_name == 'workflow_dispatch' && github.ref == format('refs/heads/{0}', github.event.repository.default_branch))) && '["self-hosted","Linux","X64","propr-rootless"]' || '["ubuntu-24.04"]') }}
timeout-minutes: 30
permissions:
contents: read
Expand Down Expand Up @@ -412,7 +412,7 @@ jobs:
${{ !cancelled() &&
(github.event_name == 'workflow_dispatch' || !github.event.pull_request.draft) &&
needs.classify.outputs.desktop != 'false' }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 20
permissions:
contents: read
Expand Down Expand Up @@ -467,7 +467,7 @@ jobs:
if: >-
${{ !cancelled() &&
(github.event_name == 'workflow_dispatch' || !github.event.pull_request.draft) }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 10
permissions:
contents: read
Expand Down Expand Up @@ -577,7 +577,7 @@ jobs:
${{ always() && !cancelled() && github.event_name == 'pull_request' &&
needs.test.result == 'failure' &&
github.event.pull_request.head.repo.full_name == github.repository }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
permissions:
contents: read
pull-requests: write
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/test-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ jobs:
native-electron:
name: Nightly Native Electron (hosted)
# The self-hosted runner does not provide the native sandbox/session contract.
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 20
permissions:
contents: read
Expand Down Expand Up @@ -320,7 +320,7 @@ jobs:
name: Nightly desktop download
needs: [full-tests, e2e-tests, native-electron, desktop-package, desktop-connect]
if: ${{ !cancelled() }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 30
permissions:
contents: read
Expand Down Expand Up @@ -412,7 +412,7 @@ jobs:
name: Nightly test health
needs: [full-tests, e2e-tests, native-electron, desktop-package, desktop-connect, desktop-nightly-download]
if: ${{ !cancelled() }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
timeout-minutes: 10
permissions:
contents: read
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- **CI runs on Ubuntu 24.04 again**: hosted Linux jobs name `ubuntu-24.04`
instead of `ubuntu-latest`, which GitHub moved to Ubuntu 26.04. The desktop
RPM build fails under that image's `rpmbuild`, so two desktop tests failed
in every full test suite run.
- **MCP-created plans open in Studio at Review**: `create_plan` called with
plan items stored the draft as `draft`, so Studio opened it at Define and
showed no issues until it was published. A draft created or updated with
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/scripts/linux-preview-workflow.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ test('regular desktop PR validation requires disposable-key and real RPM tests',
const block = guard.slice(start, guard.indexOf('\n renderer-axe-boundary:', start));
assert.match(block, /github.event_name != 'push'/);
assert.match(block, /needs.classify.outputs.desktop != 'false'/);
assert.match(block, /runs-on: ubuntu-latest/);
assert.match(block, /runs-on: ubuntu-24.04/);
assert.match(block, /sudo apt-get install --yes rpm gnupg cpio/);
assert.match(block, /PROPR_REQUIRE_RPM_TESTS: '1'/);
assert.match(block, /node --test apps\/desktop\/scripts\/rpm-signing.test.mjs/);
Expand Down
9 changes: 9 additions & 0 deletions docs/ci-runners.md
Original file line number Diff line number Diff line change
Expand Up @@ -494,3 +494,12 @@ ProPR admits issues only by its configured trigger labels (`AI` by default)
and ignores comments on issues that are not pull requests. The script refuses
to apply `AI` or `llm-*` labels, so the health issue never enters ProPR's queue.
Adding a trigger label by hand would still start an agent task.

## Hosted runner image

Hosted Linux jobs name `ubuntu-24.04` and not `ubuntu-latest`. When GitHub
moved `ubuntu-latest` to Ubuntu 26.04, `rpmbuild` there stopped building the
desktop RPM from the `electron-installer-redhat` spec (`%install` no longer
runs in the staged directory), so `apps/desktop/src/rpm-maker.test.ts` and
`apps/desktop/scripts/rpm-signing.test.mjs` failed on every run. Move to a
newer image in one change, together with the RPM packaging fix.
2 changes: 1 addition & 1 deletion test/ciFullSuiteSelection.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ describe('Full Test Suite job selection', () => {
assert.match(classify, /fetch-depth: 0\n/);
assert.match(classify, /persist-credentials: false\n/);
assert.match(classify, /permissions:\n\s+contents: read\n\s+outputs:/);
assert.match(classify, /\n {4}runs-on: ubuntu-latest\n/);
assert.match(classify, /\n {4}runs-on: ubuntu-24.04\n/);
});
});

Expand Down
Loading
Loading