Repository navigation
Fix stale delete-confirm popup by bumping grid-uikit - #185
Merged
Merged
Conversation
The delete-confirmation popup kept showing a previously selected profile's name after cancel + reselect, because grid-uikit's tooltip action never updated the already-mounted popup on prop changes. Fixed upstream in @intechstudio/grid-uikit@1.20261014.1208. That version also pulls in svelte-splitpanes@^8.0.12, which broke the webcomponent build (it imports the SvelteKit-only $app/environment). Shimmed it the same way grid-uikit's own demo and grid-editor already do. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01619XN25FUTzqut4YbzZPQr
|
Visit the preview URL for this PR (updated for commit c365715): https://profile-cloud-dev--pr185-fix-stale-delete-con-z651uvqf.web.app (expires Fri, 13 Nov 2026 12:45:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2a004f867edf1347070dd9beedb18755187a6d4e |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@intechstudio/grid-uikitto1.20261014.1208, which fixes the delete-confirmation popup showing a previously selected profile's name after cancel and reselect (thetooltipaction never updated the mounted popup on prop changes).$app/environmentshim and alias tovite.config.webcomponent.ts. The new grid-uikit pulls insvelte-splitpanes@8.0.12, which imports that SvelteKit-only module and broke the webcomponent build. Same pattern grid-uikit's demo and grid-editor use.Test plan
npm run build:webcomponentsucceeds (verified locally)npm run dev: select profile A, click delete, cancel, select profile B, click delete; popup shows B's nameMerging to
maintriggers the npm publish workflow.🤖 Generated with Claude Code
https://claude.ai/code/session_01619XN25FUTzqut4YbzZPQr