Skip to content

Updating check_scalar() to error on list input - #35

Merged
Melkiades merged 2 commits into
insightsengineering:mainfrom
ddsjoberg:check_scalar-lists
Aug 11, 2026
Merged

Updating check_scalar() to error on list input#35
Melkiades merged 2 commits into
insightsengineering:mainfrom
ddsjoberg:check_scalar-lists

Conversation

@ddsjoberg

@ddsjoberg ddsjoberg commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Reference GitHub issue associated with pull request. e.g., 'closes #'
closes #34


Pre-review Checklist (if item does not apply, mark is as complete)

  • All GitHub Action workflows pass with a ✅
  • PR branch has pulled the most recent updates from master branch: usethis::pr_merge_main()
  • If a bug was fixed, a unit test was added.
  • If a standalone script was updated, a comment is added to the script header (changelog) AND the last-updated field has been updated.
  • Code coverage is suitable for any new functions/features (generally, 100% coverage for new code): devtools::test_coverage()
  • Request a reviewer

Reviewer Checklist (if item does not apply, mark is as complete)

  • If a bug was fixed, a unit test was added.
  • If a standalone script was updated, a comment is added to the script header (changelog) AND the last-updated field has been updated.
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features: devtools::test_coverage()

When the branch is ready to be merged:

  • All GitHub Action workflows pass with a ✅
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge" or "Rebase and merge".
  • Create an issue in any repositories using {standalone} to update the standalone scripts.

@Melkiades Melkiades left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks Daniel :)

@Melkiades
Melkiades merged commit a762d40 into insightsengineering:main Aug 11, 2026
8 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check_scalar() allows for a list of length 1 (and I don't think that is how we intended it to be used)

2 participants