Update imported {standalone} scripts to current source (#280) - #281
Merged
Conversation
Refresh the standalone helper files imported from insightsengineering/standalone to their current main versions via usethis::use_standalone(): - import-standalone-checks.R (2024-05-04 -> 2025-05-08) - import-standalone-stringr.R (2024-11-01 -> 2026-06-30) - import-standalone-tibble.R (2024-05-07 -> 2026-06-30) - import-standalone-forcats.R (2025-07-25 -> 2026-06-30) DESCRIPTION was intentionally left unchanged; use_standalone() removed existing version pins, which is out of scope for a source refresh.
Contributor
Author
|
I would only wait for insightsengineering/standalone#33 |
Contributor
Unit Tests Summary 1 files 260 suites 3m 7s ⏱️ Results for commit aa1c988. ♻️ This comment has been updated with latest results. |
Contributor
|
Code Coverage SummaryDiff against mainResults for commit: aa1c988 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit 320c776 ♻️ This comment has been updated with latest results. |
Contributor
Author
|
deepends on insightsengineering/standalone#33 |
check_*() functions now error on empty input when allow_empty = FALSE, and check_scalar_integerish() failures use their own condition class.
Syncs the latest upstream change (insightsengineering/standalone#35): check_scalar() now errors on a length-1 list, and the length-1 message reads 'must be a vector of length 1'. Updated the tbl_survfit_times snapshot to match the new wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
{standalone}scripts (checks,stringr,tibble,forcats) to their current source versions. (Update imported {standalone} scripts to current source #280, @Melkiades)Synced the standalone helper files imported from
insightsengineering/standaloneto their currentmainversions viausethis::use_standalone():import-standalone-checks.Rimport-standalone-stringr.Rimport-standalone-tibble.Rimport-standalone-forcats.RThe
checksrefresh carries a few behavior changes from upstream:check_*()functions now error on empty input whenallow_empty = FALSE(previously empty input silently passed). (standalone#30)check_scalar()now errors on a length-1 list, and the length-1 error message reads "must be a vector of length 1". (standalone#35)check_scalar_integerish()failures use their own condition class.The crane test suite passes with these changes; the only snapshot update is the reworded
check_scalar()message intbl_survfit_times.check_pkg_installedandcli_call_envalready matched the source and were left unchanged.import-standalone-purrr.Ris sourced fromr-lib/rlangand is out of scope.DESCRIPTIONwas intentionally left unchanged:use_standalone()stripped existing version pins (e.g.rlang (>= 1.1.5)), which is out of scope for a source refresh.Reference GitHub issue associated with pull request. closes #280
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()devtools::test_coverage()Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()When the branch is ready to be merged:
NEWS.mdwith the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).