Skip to content

Correct floating comment editor layout #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chee merged 3 commits into from
Sep 9, 2026
Merged

Correct floating comment editor layout #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e641b0a
Initial plan
Copilot Sep 8, 2026
8962764
Fix floating comment editor sizing selector
Copilot Sep 8, 2026
47b09d9
Constrain comment editor layout
Copilot Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion codemirror-base/src/lib/extensions/commentUI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,9 +407,24 @@ const commentUITheme = EditorView.baseTheme({
// The draft textarea is width:100% with its own padding + border; without
// border-box it spills out of the card's right edge (the card's own reset is
// scoped to the sidebar panel, which the popover isn't inside).
".cm-comment-popover .comment-draft-textarea": {
".cm-comment-popover .comment-draft-editor": {
boxSizing: "border-box",
maxWidth: "100%",
minWidth: "0",
width: "100%",
},
".cm-comment-popover .comment-draft-editor .cm-content": {
minHeight: "0",
minWidth: "0",
margin: "0",
padding: "8px",
},
".cm-comment-popover .comment-draft-editor .cm-line": {
margin: "0",
padding: "0",
},
".cm-comment-popover .comment-draft-editor .cm-scroller": {
minWidth: "0",
},
});

Expand Down
13 changes: 12 additions & 1 deletion comments-view/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@
.comment-draft-editor {
height: 6rem;
min-height: 6rem;
min-width: 0;
width: 100%;
border: 1px solid var(--comments-border);
border-radius: 0.5rem;
color: var(--comments-fg);
Expand All @@ -208,11 +210,20 @@

.comment-draft-editor .cm-content {
box-sizing: border-box;
min-height: 100%;
min-height: 0;
min-width: 0;
margin: 0;
padding: 0.5rem;
}

.comment-draft-editor .cm-line {
margin: 0;
padding: 0;
}

.comment-draft-editor .cm-scroller {
height: 100%;
min-width: 0;
}

.comment-draft-editor:focus-within {
Expand Down
Loading