Skip to content

Remove incorrect HTTP package import warning - #55

Merged
chee merged 4 commits into
mainfrom
copilot/fix-host-import-http-error
Sep 11, 2026
Merged

Remove incorrect HTTP package import warning#55
chee merged 4 commits into
mainfrom
copilot/fix-host-import-http-error

Conversation

Copilot AI commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

The package installer reported that host builds cannot import HTTP(S) packages, even though the host supports those imports. This produced a misleading warning while previewing valid package URLs.

  • Package discovery

    • Remove the obsolete filesystem-version guard and its incorrect error.
    • Call the host HTTP module importer directly.
  • Regression coverage

    • Add coverage for discovering plugin descriptors from an HTTPS package URL.
const mod = await filesystem.importModuleFromHttpUrl(url);

Co-authored-by: chee <178266+chee@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix incorrect error message for importing http(s) packages Remove incorrect HTTP package import warning Sep 8, 2026
Copilot AI requested a review from chee September 8, 2026 15:13
@patchcrow

patchcrow commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

✅ Patchwork glance ready

https://patchwork-preview-55--patchwork-base.netlify.app

Patchwork from inkandswitch/patchwork.inkandswitch.com, packages from this PR at 95b9446.

build-info.json

@chee

chee commented Sep 9, 2026

Copy link
Copy Markdown
Member

@copilot filesystem.importModuleFromHttpUrl is not a function

Co-authored-by: chee <178266+chee@users.noreply.github.com>

Copilot AI commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

@copilot filesystem.importModuleFromHttpUrl is not a function

Fixed in ab31573. Package discovery now uses a direct Vite-ignored dynamic import rather than the unavailable filesystem API.

@chee

chee commented Sep 9, 2026

Copy link
Copy Markdown
Member

@copilot filesystem.importModuleFromHttpUrl is not a function

Fixed in ab31573. Package discovery now uses a direct Vite-ignored dynamic import rather than the unavailable filesystem API.

don't think that's the solution m8

Co-authored-by: chee <178266+chee@users.noreply.github.com>

Copilot AI commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

@copilot filesystem.importModuleFromHttpUrl is not a function

Fixed in ab31573. Package...

Corrected in 95b9446. The host API was renamed to importPackageFromHttpUrl; this updates the filesystem dependency to 0.2.7, which exports it, and uses that importer.

@chee
chee marked this pull request as ready for review September 11, 2026 18:11
@chee
chee merged commit 7982bec into main Sep 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Host can't import http(s) packages error but it actually can

3 participants