test: provide conditions for lens count-scope regressions - #95
Draft
agreenspan wants to merge 1 commit into
Draft
Conversation
This was referenced Sep 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two lensWhere integration tests failed before reaching their soft-delete assertions because their
atLeastrules omitted the required inner condition. The count API deliberately treats that omission as an authoring error in both json-rules 2.20.0 and 2.21.0.Add
condition: trueto mean count every candidate child. Keep both database assertions unchanged: a tombstoned Contact cannot satisfy the count, and Session counting works without a deletedAt column. The production scope implementation remains responsible for live-row filtering.Validation: all 1,006 API tests pass against the existing locked dependencies after configuring the local MinIO test environment. API typecheck passes. Adversarial review confirmed the two rules preserve the intended test semantics.
bun run checkstill stops at 134 existing lint errors in unchanged files, so this PR is draft pending the repository-wide gate.No dependency versions, production code, CI rules or CI fixtures changed.