chore(frontend): tailwind-variants, theme tokens, global styles in css - #3983
Open
Kadrian wants to merge 1 commit into
Open
chore(frontend): tailwind-variants, theme tokens, global styles in css#3983Kadrian wants to merge 1 commit into
Kadrian wants to merge 1 commit into
Conversation
Kadrian
marked this pull request as draft
August 27, 2026 11:38
Kadrian
force-pushed
the
chore/tailwind-variants
branch
from
August 27, 2026 14:36
63dab72 to
2654fe8
Compare
Kadrian
force-pushed
the
chore/tailwind-variants
branch
from
August 27, 2026 14:40
2654fe8 to
93091f4
Compare
groundwork for removing emotion: tv replaces tailwind-styled-components, the emotion theme's colors/fonts/radius exist as @theme tokens, GlobalStyles is plain css
Kadrian
force-pushed
the
chore/tailwind-variants
branch
from
August 27, 2026 14:43
93091f4 to
02d8119
Compare
Kadrian
marked this pull request as ready for review
August 27, 2026 14:44
thoniTUB
approved these changes
Aug 28, 2026
awildturtok
approved these changes
Aug 31, 2026
| `; | ||
| const headline = tv({ | ||
| base: "mt-[6px] mr-[5px] mb-0 shrink-0 cursor-pointer border-b-[3px] px-3 text-sm font-bold uppercase leading-[30px] tracking-wider transition-colors", | ||
| variants: { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step of the emotion → tailwind migration.
tailwind-variantsin,tailwind-styled-componentsout; its 7 usages aretv()now. Notailwind-merge: tv 3 ships its own class merger,classNameoverrides go through it (heading3({ className })); pnpm still resolves it as an optional peer in the lockfile, not a direct deptv(), conditionals are variants, longer lists use the array form with one utility per line (only tightly coupled ones share a line, e.g.absolute top-3 right-4,opacity-80 hover:opacity-100)@themegains what only the emotion theme had:red/green/orange,filetype-*,text-tiny(11px), barerounded= 3px. Other font sizes map onto tailwind defaults (xs/sm/base/xl/2xl)GlobalStyles.tsx→@layer baseinindex.css, tippy overrides too; dead.SplitPane/.Resizerrules dropped<button>s now (a11y rules see raw elements,tw()hid them)Follow-ups: migrate
styled()per directory (~200 files), then drop@emotion/*+ shrinkconquery({ theme })to{ img, palette }. Downstream repo must mirror the dependency change and already overrides the tokens via:root.