refactor(frontend): drop React.FC, type props inline - #3981
Merged
Conversation
FC is legacy (implicit children gone since react 18); inline single-use props types to match the prevailing style
react 19 passes ref as a regular prop; forwardRef is deprecated. Generic dropzones no longer need the 'as <T>(...)' cast
awildturtok
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FCis legacy: no implicitchildrensince react 18, nothing else it addsPropsinterfaces inlined, reused/exported ones kept (CSVColumnPicker)/* <FC<DropzoneProps<…>>> */comments removedPure type-level change, no runtime diff. biome, tsc, vitest, build green.