feat: adapt postQuery to allow setting of external query - #3940
Merged
Conversation
awildturtok
force-pushed
the
feature/providable-query-id
branch
2 times, most recently
from
August 17, 2026 10:38
a2adf0b to
079490a
Compare
awildturtok
force-pushed
the
feature/providable-query-id
branch
2 times, most recently
from
August 17, 2026 15:57
813450b to
31f586a
Compare
thoniTUB
requested changes
Aug 20, 2026
awildturtok
force-pushed
the
feature/providable-query-id
branch
from
August 25, 2026 10:29
31f586a to
9326136
Compare
awildturtok
force-pushed
the
feature/providable-query-id
branch
from
August 25, 2026 11:36
9326136 to
9a9b940
Compare
thoniTUB
requested changes
Aug 26, 2026
thoniTUB
left a comment
thoniTUB
left a comment
Collaborator
There was a problem hiding this comment.
Ich würde noch ein paar dinge aufräumen
thoniTUB
changed the title
awildturtok
force-pushed
the
feature/providable-query-id
branch
from
August 27, 2026 11:06
0f4393c to
44d1a7a
Compare
awildturtok
enabled auto-merge (squash)
August 27, 2026 12:05
thoniTUB
requested changes
Sep 1, 2026
|
|
||
| @Override | ||
| public boolean isValid(UUID id, ConstraintValidatorContext context) { | ||
| return id == null || id.version() != 4; |
Collaborator
There was a problem hiding this comment.
Suggested change
| return id == null || id.version() != 4; | |
| return id == null || id.version() == 4; |
awildturtok
force-pushed
the
feature/providable-query-id
branch
from
September 1, 2026 15:48
824b5fe to
bdeebb7
Compare
thoniTUB
approved these changes
Sep 2, 2026
| IntegrationUtils.assertQueryResult(conquery, reused2, uuid, expectedSize, ExecutionState.DONE, conquery.getTestUser(), 201); | ||
|
|
||
| assertThat(reused2Id) | ||
| .as("Query should be reused.") |
Collaborator
There was a problem hiding this comment.
Suggested change
| .as("Query should be reused.") | |
| .as("Execution should not be reused, because id is explicitly provided.") |
Collaborator
There was a problem hiding this comment.
Den Check kannst du aber auch nach IntegrationUtils.assertQueryResult verschieben.
Collaborator
There was a problem hiding this comment.
Kannst du bitte noch Tests für die Rejection hinzufügen, wenn die ID schon verwendet wurde.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.