Updated DHCP Configuration models in IPAM - #44
Merged
Conversation
unasra
approved these changes
Jul 13, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the IPAM DHCP configuration models to include newly supported DHCP settings, keeping the generated Python client models and their documentation in sync with the underlying API schema.
Changes:
- Added
authoritative_dhcptoDHCPConfigandInheritedDHCPConfig. - Added
hold_reclaimed_timeandhold_reclaimed_time_v6toDHCPConfigandInheritedDHCPConfig. - Updated model serialization/deserialization (
__properties,to_dict,from_dict) and corresponding Markdown docs for the new fields.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/ipam/models/inherited_dhcp_config.py | Adds inheritance wrappers + serialization/deserialization for authoritative_dhcp and hold-reclaimed timers. |
| src/ipam/models/dhcp_config.py | Adds concrete config fields + updates __properties and from_dict defaults for the new DHCP settings. |
| src/ipam/docs/InheritedDHCPConfig.md | Documents the newly added inherited DHCP config fields. |
| src/ipam/docs/DHCPConfig.md | Documents the newly added DHCP config fields and their defaults. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds new fields to the
DHCPConfigandInheritedDHCPConfigmodels in theipampackage to align the Python client with the latest IPAM API schema for DHCP configuration options.Type of Change
Affected Packages
anycastcloud_discoverydfpdns_configdns_datadtcfwinfra_mgmtinfra_provisionipamipam_federationkeysredirectupgrade_policyuniversal_ddi_clientResource / Model:
DHCPConfig,InheritedDHCPConfigDescription: Added new optional fields to
DHCPConfigandInheritedDHCPConfigto reflect updated IPAM API schema.Schema Changes
Detailed Changes (click to expand)
src/ipam/models/dhcp_config.pysrc/ipam/models/inherited_dhcp_config.pysrc/ipam/docs/DHCPConfig.mdsrc/ipam/docs/InheritedDHCPConfig.mdTicket / Issue
Fixes #
Changelog Inclusion
Additional Context
These model changes ensure the Python client can round-trip all DHCP configuration options returned by the IPAM API without losing data on read.