Skip to content

Updated DHCP Configuration models in IPAM - #44

Merged
unasra merged 1 commit into
infobloxopen:mainfrom
Tejashree-RS:upam-dhcp-config-models
Jul 13, 2026
Merged

Updated DHCP Configuration models in IPAM#44
unasra merged 1 commit into
infobloxopen:mainfrom
Tejashree-RS:upam-dhcp-config-models

Conversation

@Tejashree-RS

@Tejashree-RS Tejashree-RS commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds new fields to the DHCPConfig and InheritedDHCPConfig models in the ipam package to align the Python client with the latest IPAM API schema for DHCP configuration options.

Type of Change

  • 🆕 New API / Model
  • 🔧 Update Existing Schema or Model
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧹 Maintenance (dependency upgrades, CI, refactoring)

Affected Packages

  • anycast
  • cloud_discovery
  • dfp
  • dns_config
  • dns_data
  • dtc
  • fw
  • infra_mgmt
  • infra_provision
  • ipam
  • ipam_federation
  • keys
  • redirect
  • upgrade_policy
  • universal_ddi_client

Resource / Model: DHCPConfig, InheritedDHCPConfig
Description: Added new optional fields to DHCPConfig and InheritedDHCPConfig to reflect updated IPAM API schema.

Schema Changes

  • New model added
  • New field(s) added to existing model
  • Field(s) removed or renamed
  • Required fields changed
Detailed Changes (click to expand)
File Change
src/ipam/models/dhcp_config.py Added new optional DHCP configuration fields
src/ipam/models/inherited_dhcp_config.py Added corresponding inherited field definitions
src/ipam/docs/DHCPConfig.md Updated documentation to include new fields
src/ipam/docs/InheritedDHCPConfig.md Updated documentation to include new inherited fields

Ticket / Issue

Fixes #

Changelog Inclusion

  • Consider for changelog and release notes addition

Additional Context

These model changes ensure the Python client can round-trip all DHCP configuration options returned by the IPAM API without losing data on read.

@unasra unasra changed the title Updated DHCP Configuration models in UPAM Updated DHCP Configuration models in IPAM Jul 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the IPAM DHCP configuration models to include newly supported DHCP settings, keeping the generated Python client models and their documentation in sync with the underlying API schema.

Changes:

  • Added authoritative_dhcp to DHCPConfig and InheritedDHCPConfig.
  • Added hold_reclaimed_time and hold_reclaimed_time_v6 to DHCPConfig and InheritedDHCPConfig.
  • Updated model serialization/deserialization (__properties, to_dict, from_dict) and corresponding Markdown docs for the new fields.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/ipam/models/inherited_dhcp_config.py Adds inheritance wrappers + serialization/deserialization for authoritative_dhcp and hold-reclaimed timers.
src/ipam/models/dhcp_config.py Adds concrete config fields + updates __properties and from_dict defaults for the new DHCP settings.
src/ipam/docs/InheritedDHCPConfig.md Documents the newly added inherited DHCP config fields.
src/ipam/docs/DHCPConfig.md Documents the newly added DHCP config fields and their defaults.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@unasra
unasra merged commit 5dba2e6 into infobloxopen:main Jul 13, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants