[DNS DATA] Update name_in_zone to set default as None for Python Client - #37
Merged
Merged
Conversation
unasra
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets
name_in_zoneto default toNoneon theRecordmodel so that records without a name prefix (e.g. apex records) can be created without supplying this field. Also addscompartment_idsupport for DNS Zone scoping, as noted in the PR description.Type of Change
Affected Packages
anycastcloud_discoverydfpdns_configdns_datadtcfwinfra_mgmtinfra_provisionipamipam_federationkeysredirectupgrade_policyuniversal_ddi_clientResource / Model:
RecordDescription: Made
name_in_zoneoptional with a default ofNone; added compartment_id field for Zone scoping.Schema Changes
Detailed Changes (click to expand)
src/dns_data/models/record.pyname_in_zonetoOptional[str] = None; addedcompartment_idfieldsrc/dns_data/docs/Record.mdTicket / Issue
Fixes #28 and #29
Changelog Inclusion
Additional Context
Previously, omitting
name_in_zonewould cause a validation error even for apex-level records where no name prefix is expected. Setting the default toNoneallows the field to be omitted and lets the API apply its own default behaviour.