Initial package implementation - #5
Open
dnguyen227 wants to merge 8 commits into
Open
Conversation
dnguyen227
force-pushed
the
package_updates
branch
from
August 23, 2026 18:46
4877613 to
890b547
Compare
Collaborator
Author
|
@pulsipher ready for review. |
pulsipher
requested changes
Sep 4, 2026
pulsipher
left a comment
Contributor
There was a problem hiding this comment.
A few comments/questions:
- I believe this requires that we first at support for MOI disjunctions in DisjunctiveProgramming, right?
- It doesn't appear that this optimizer supports the full MOI API for queries (i.e., not requiring the user to call the inner solver directly)
- Are the methods in the main src folder truly general and not specific to LOA? (especially master.jl and nlp.jl)
- It would be good to have a test for the natural user interface via DisjunctiveProgramming
Comment on lines
+56
to
+62
| function _try_convert(T::Type, func) | ||
| return try | ||
| convert(T, func) | ||
| catch | ||
| func | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
generally, try catch statements should be avoided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sample how we'd use this: