Repository navigation
test(e2e): read Redis lifecycle limits from execution spec - #101
Merged
rcyw merged 1 commit intoOct 16, 2026
Merged
Conversation
The persisted EnvironmentSpec stores limits under execution. Reading the retired sandbox key raises KeyError before the limit and command checks. Use the current field while preserving the node-pin, held-resource, CPU, memory, command and deletion assertions. Signed-off-by: wayne <rcywjo@gmail.com>
Collaborator
|
lgtm |
WenYuLuo
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Redis lifecycle node-pin/delete case reads limits from the retired
spec.sandboxfield and raisesKeyErrorbefore checking the configured limits and command execution. Readspec.execution.limits, matching the current persisted EnvironmentSpec, while preserving all existing assertions.Validation:
python -m tests.e2e.run --level full --case redis-lifecycle --require-clean-redis: all four cases pass, zero skips, with a clean Redis reservation ledger before and after.9f247186, sandboxdd5886b42and ADX/Execdce80a189. The image and production SDK code are unchanged; the SDK imports from the candidate checkout. The complete E2E suite was not rerun.