chore(immutable-x): Add console.logs for debugging issues during starkex gen - #2596
Open
brayansdt wants to merge 8 commits into
Open
chore(immutable-x): Add console.logs for debugging issues during starkex gen#2596brayansdt wants to merge 8 commits into
brayansdt wants to merge 8 commits into
Conversation
brayansdt
changed the title
|
View your CI Pipeline Execution ↗ for commit faae51e.
☁️ Nx Cloud last updated this comment at |
brayansdt
changed the title
brayansdt
force-pushed
the
fix/add-logs-for-encoding-stark-key-gen
branch
2 times, most recently
from
March 26, 2025 05:10
8f08c0f to
21a3c93
Compare
Replaces string-based signature message with raw bytes in stark key generation to prevent encoding issues in non-English systems. This aligns with the fix for wallet connection message encoding.
- Add debug logs to track utf-8 byte encoding/decoding - Compare utf-8 bytes between TextEncoder/TextDecoder and ethers.toUtf8Bytes - Attempt to fix encoding issue by using ethers.toUtf8Bytes directly for signing - Add validation that encoded bytes match expected connection string
brayansdt
force-pushed
the
fix/add-logs-for-encoding-stark-key-gen
branch
from
March 27, 2025 06:42
00b71b7 to
9e19a78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added logging to debug Stark key generation and message signing issues, particularly focusing on UTF-8 encoding of messages. This is for alpha release only and contains no sensitive information.
Detail and impact of the change
Changed
signRawfunction to usetoUtf8Bytesfor message signingImxSignerimxWalletmetaMaskWrapperAnything else worth calling out?
This PR should help identify the root cause of the Stark signature verification failures by providing visibility into the message encoding and signing process. The logging is intended for alpha testing only and will be removed before any production release.