fix: accept mixed indices for buffer access#620
Open
nahime0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buffer<T>reads and writes to acceptMixedindices produced by non-constant integer arithmetic.MixedtoIntin EIR before backend bounds and address checks.Unreleasedchangelog entry.Context
Checked integer addition, subtraction, and multiplication produce a boxed
Mixedresult so they can promote tofloatonoverflow. Buffer indexing still required a statically concrete
Int, causing these indices to fail during type checking or EIRbackend lowering.
Buffer writes already performed the appropriate EIR coercion. This change makes reads follow the same target-neutral path while
allowing
Mixedindices through the checker for both operations.Fixes #497
Testing
cargo buildcargo test --test codegen_tests codegen::buffers::— 15 passedcargo test --test error_tests buffer_— 16 passedgit diff --check