feat: Add attribute combination support to graph operators by schochastics · Pull Request #2676 · igraph/rigraph

schochastics · 2026-05-28T11:37:31Z

…tion, compose, disjoint_union)

schochastics · 2026-05-28T11:59:26Z

devtools::document() doesnt work locally for me

krlmlr · 2026-06-04T08:45:14Z

+make_named_pair <- function() {
+  g1 <- graph_from_literal(A - B, B - C, C - A)
+  g2 <- graph_from_literal(A - B, B - C, C - A)
+  V(g1)$weight <- c(1, 2, 3)
+  V(g2)$weight <- c(10, 20, 30)
+  E(g1)$weight <- c(1, 2, 3)
+  E(g2)$weight <- c(10, 20, 30)
+  list(g1 = g1, g2 = g2)
+}


Move to helper or a proper R/ function?

krlmlr · 2026-06-04T08:49:27Z

 #############

-igraph.i.attribute.combination <- function(comb) {
+igraph.i.attribute.combination <- function(comb, allow_rename = FALSE) {


Split into two functions, one for a scalar, and the list function as a simple wrapper?

krlmlr · 2026-06-04T08:52:36Z

+  default_comb <- if (length(default_idx) > 0) {
+    comb[[default_idx[1]]]
+  } else {
+    "rename"


Suggested change

"rename"

# Backward-compatible standard

"rename"

krlmlr · 2026-06-04T09:11:10Z

 #' print_all(g1 %du% g2)
 #' @export
-disjoint_union <- function(...) {
+disjoint_union <- function(..., graph.attr.comb = "rename") {


Suggested change

disjoint_union <- function(..., graph.attr.comb = "rename") {

disjoint_union <- function(..., graph_attr_comb = "rename") {

and clean up edge.attr.comb ? Think harder about naming, but the names already are long enough.

krlmlr · 2026-06-04T09:12:07Z

 ###################################################################

-rename.attr.if.needed <- function(
+combine.attrs <- function(


Keep rename_attr_if_needed() and use it only for those attributes where the action is "rename"?

Run: https://github.com/igraph/rigraph/actions/runs/27070207213

github-actions · 2026-06-10T07:05:06Z

This is how benchmark results would change (along with a 95% confidence interval in relative change) if c26ab02 is merged into main:

✔️as_adjacency_matrix: 777ms -> 779ms [-0.27%, +0.78%]
✔️as_biadjacency_matrix: 777ms -> 779ms [-0.47%, +1.17%]
✔️as_data_frame_both: 1.61ms -> 1.59ms [-2.88%, +1.5%]
✔️as_long_data_frame: 4ms -> 4ms [-1.29%, +1.34%]
✔️es_attr_filter: 2.8ms -> 2.82ms [-1.01%, +2.48%]
✔️graph_from_adjacency_matrix: 147ms -> 148ms [-0.73%, +1.43%]
✔️graph_from_data_frame: 3.56ms -> 3.56ms [-1.83%, +1.32%]
✔️vs_attr_filter: 1.65ms -> 1.63ms [-3.3%, +0.25%]
✔️vs_by_name: 1.06ms -> 1.06ms [-2.31%, +2.11%]
Further explanation regarding interpretation and methodology can be found in the documentation.

…lper Address review feedback on #2676: - Rename the new graph.attr.comb/vertex.attr.comb/edge.attr.comb arguments of union()/intersection()/compose()/disjoint_union() to snake_case (these args are new in this PR, so no deprecation is needed). - Extract rename_attr_if_needed() back out of combine.attrs() for the "rename" strategy, preserving the historical overwrite-on-clash semantics under chains of %du%. - Add a clarifying comment on the backward-compatible "rename" default. - Move the make_named_pair() test helper into helper.R. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…tted names Follow-up to review feedback on #2676 ("clean up edge.attr.comb"): - simplify(), as_undirected() and contract() gain snake_case edge_attr_comb / vertex_attr_comb arguments via the argument-migration infrastructure (tools/migrations.R). The old dotted names still work and emit a single lifecycle::deprecate_soft() warning. - Rename the matching igraph option keys edge.attr.comb -> edge_attr_comb and vertex.attr.comb -> vertex_attr_comb, with back-compatible aliasing in igraph_opt()/igraph_options(); the dotted keys still read and set, soft- deprecated. Update the stimulus codegen default (types-RR.yaml) and the regenerated *_impl defaults to match. Deprecated wrappers (as.undirected(), contract.vertices()) are left frozen; their snapshot now records the resulting layered deprecation warnings. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Run: https://github.com/igraph/rigraph/actions/runs/27270008480

github-actions · 2026-06-10T10:43:04Z

This is how benchmark results would change (along with a 95% confidence interval in relative change) if b58da44 is merged into main:

✔️as_adjacency_matrix: 731ms -> 728ms [-1.46%, +0.89%]
✔️as_biadjacency_matrix: 735ms -> 740ms [-0.52%, +1.76%]
✔️as_data_frame_both: 1.51ms -> 1.5ms [-2.15%, +1.45%]
✔️as_long_data_frame: 4.06ms -> 4.05ms [-3.39%, +2.93%]
✔️es_attr_filter: 2.9ms -> 2.93ms [-3.59%, +5.69%]
✔️graph_from_adjacency_matrix: 118ms -> 119ms [-0.35%, +2.21%]
✔️graph_from_data_frame: 3.54ms -> 3.58ms [-1.51%, +4.05%]
✔️vs_attr_filter: 1.66ms -> 1.66ms [-2.81%, +3.13%]
✔️vs_by_name: 1.05ms -> 1.09ms [-4.13%, +11.57%]
Further explanation regarding interpretation and methodology can be found in the documentation.

krlmlr · 2026-06-11T09:04:18Z

+  "vertex_attr_comb" = list(name = "concat", "ignore"),
+  "edge_attr_comb" = list(weight = "sum", name = "concat", "ignore"),


"graph_attr_comb" missing?

Add attribute combination support to graph operators (union, intersec…

c75e174

…tion, compose, disjoint_union)

schochastics added the hackathon-topic 📆 label May 28, 2026

krlmlr and others added 2 commits May 28, 2026 20:00

Merge branch 'main' into feat-attrib_comb

41c4b0c

make document work locally

5f7521a

krlmlr reviewed Jun 4, 2026

View reviewed changes

schochastics and others added 3 commits June 6, 2026 20:20

Merge branch 'main' into feat-attrib_comb

cb49b91

chore: Auto-update from GitHub Actions

d7e8bdc

Run: https://github.com/igraph/rigraph/actions/runs/27070207213

Merge branch 'main' into feat-attrib_comb

c26ab02

igraph deleted a comment from github-actions Bot Jun 10, 2026

schochastics and others added 3 commits June 10, 2026 12:27

chore: Auto-update from GitHub Actions

04ab715

Run: https://github.com/igraph/rigraph/actions/runs/27270008480

krlmlr reviewed Jun 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add attribute combination support to graph operators#2676

feat: Add attribute combination support to graph operators#2676
schochastics wants to merge 9 commits into
mainfrom
feat-attrib_comb

schochastics commented May 28, 2026

Uh oh!

schochastics commented May 28, 2026

Uh oh!

krlmlr Jun 4, 2026

Uh oh!

krlmlr Jun 4, 2026

Uh oh!

krlmlr Jun 4, 2026

Uh oh!

krlmlr Jun 4, 2026

Uh oh!

krlmlr Jun 4, 2026

Uh oh!

krlmlr Jun 4, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

krlmlr Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	disjoint_union <- function(..., graph.attr.comb = "rename") {
	disjoint_union <- function(..., graph_attr_comb = "rename") {

		"vertex_attr_comb" = list(name = "concat", "ignore"),
		"edge_attr_comb" = list(weight = "sum", name = "concat", "ignore"),

Uh oh!

Conversation

schochastics commented May 28, 2026

Uh oh!

schochastics commented May 28, 2026

Uh oh!

krlmlr Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

krlmlr Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

krlmlr Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

krlmlr Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

krlmlr Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

krlmlr Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

krlmlr Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants