added: deleteNotification method which instantly removes notification…#56
Open
pollen8 wants to merge 2 commits into
Open
added: deleteNotification method which instantly removes notification…#56pollen8 wants to merge 2 commits into
pollen8 wants to merge 2 commits into
Conversation
added 2 commits
August 9, 2016 11:32
…, rather than removeNotification() which applies animation. Useful when a loading and a success message follow each other in quick succession, as the loading notificaitons animation had not yet terminated, causing an odd slide in and down to occur
|
I really need this too |
Owner
|
Sorry the delay on this. @pollen8 can you doc this on README too? |
syndbg
reviewed
Mar 19, 2017
| this.state.notifications.forEach(function(item, index) { | ||
| if (item.uid === uid) { | ||
| self.state.notifications.splice(index, 1); | ||
| } |
Collaborator
There was a problem hiding this comment.
You must never ever edit the state w/o setState.
|
@igorprado Will this also be in the 1.0.0 version? Would be a great addition |
syndbg
reviewed
Mar 23, 2017
| } | ||
| }); | ||
| } | ||
| }); |
Collaborator
There was a problem hiding this comment.
Can you reuse getNotificationRef from https://github.com/igorprado/react-notification-system/pull/89/files ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, rather than removeNotification() which applies animation. Useful when a loading and a success message follow each other in quick succession, as the loading notificaitons animation had not yet terminated, causing an odd slide in and down to occur