fix: preserve cell identity in commit callbacks - #439
Open
sameerdeolalikar wants to merge 1 commit into
Open
sameerdeolalikar wants to merge 1 commit into
sameerdeolalikar wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #428. Fixes #272.
After editing one cell and deleting another,
onCellCommitcan report the last edited cell's coordinates instead of the deleted cell. Entering and leaving an unchanged cell can also emit a commit with a null previous value, and replacing the callback can replay the last commit.Store the coordinate with each internally produced commit rather than deriving it from the global
lastChangedfield. Track actual edit entry/exit to retain the pre-edit value, and advance the delivered-commit reference before invoking callbacks. Clear, paste and cut/paste paths now attach their own coordinates; single-cell cut/paste also reports the removed source. The coordinate is optional in the exported commit type to preserve compatibility with externally constructed records, with the existing coordinate fallback retained.Validation:
Spreadsheet.tsx:223.rollup.config.mjsimport-attribute syntax,website/docusaurus.config.tssyntax, and two website formatting warnings; these files are outside this patch.The interaction checks use the repository's React Testing Library/JSDOM suite; no browser-rendering claim is made.
Implementation and regression tests were prepared with AI assistance. The checks above were executed locally.