You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I really hope that GFM is added soon to markd. In the meantime, I created a cr-cmark-gfm, a shard that binds to the official GFM C library. You can render to multiple formats, create custom nodes, renderers, etc. If you need full support of GFM in crystal give it a try. PRs welcome!
Just to be clear, my comment was not a request for you to take care of this.
Why don't you start a discussion about transferring ownership of the project? I think https://forum.crystal-lang.org/ would be a good place to find a solution for a community-supported new home.
I'm sure we'll find a good way to move forward. markd is an important piece of Crystal's ecosystem. Thank you very much for creating it and taking care of it!
the Char between the column is ……, it's a full width character, I can input it use keyboard ^ when enable Chinese input method(fcitx) in Linux, it will be replace with "\u{3000}", which is a Chinese full width Space, it can show a really space even in the
tag.
following is the replacement code:
text = text.gsub(/……(?=……| )/, " ").gsub("…", "")
Markd.to_html(text)
Following is the rendered result use markd
Not pefect, but useable, and write quickly too.
I am thinking, maybe we can use this trick to add a poor person's version of the table?
I am stumped about how to make the footnote definition work as a container in #78
Surely I am missing the exact combination of Match::Container ans parser.advance or whatever.
This is needed because the content of the definition are basically to be parsed as part of the document, they may include blocks (code blocks, blockquotes, etc)
Sorry but at the end of my rope with that, so unless someone gives a hand it's probably not going to progress further.
I've been meaning to take a look at your PR to see if I could help get it over the line, life stuff has gotten in the way recently though. Should have time soon.
@nobodywasishere no worries, I suspect tables is a much more interesting thing for users than footnotes, so a release without that PR should still be nice :-)
Activity
[-]support GFM[/-][+]GFM support [/+]drum445 commentedon Mar 12, 2019
Will this include dimensions for images?
Usually done via:
watzon commentedon Jun 20, 2019
Until this is added I do have support for gfm in my octokit.cr shard. The downside is that it has to make http requests to github's api, but it works.
icyleaf commentedon Jun 25, 2019
Smart, but the best solution is to use javascript markdown library for now 🤣
amauryt commentedon Oct 14, 2019
I really hope that GFM is added soon to markd. In the meantime, I created a cr-cmark-gfm, a shard that binds to the official GFM C library. You can render to multiple formats, create custom nodes, renderers, etc. If you need full support of GFM in crystal give it a try. PRs welcome!
nanobowers commentedon Jul 11, 2021
Emoji does not appear to really be part of cmark-gfm, FWIW per: github/cmark-gfm#75
Guess that leaves tables and task-lists.
straight-shoota commentedon Mar 15, 2022
Tables are probably the most commonly used feature of GFM. They're dearly missed in
markd.icyleaf commentedon Mar 21, 2022
I'm currently focused on my work and no more time on Crystal language, as I mentioned before I would like to donate the project to crystal officials.
Sorry about this 🥲
straight-shoota commentedon Mar 21, 2022
Just to be clear, my comment was not a request for you to take care of this.
Why don't you start a discussion about transferring ownership of the project? I think https://forum.crystal-lang.org/ would be a good place to find a solution for a community-supported new home.
I'm sure we'll find a good way to move forward.
markdis an important piece of Crystal's ecosystem. Thank you very much for creating it and taking care of it!nobodywasishere commentedon Mar 27, 2024
I've started working on this here. So far I've done strikethrough, hope to get to the rest soon.
zw963 commentedon Feb 4, 2025
after use markd several days, I find the
tablefeature is still missing ...nobodywasishere commentedon Feb 4, 2025
That is correct. Tables are complex and will require a lot of work to fit into the existing architecture (which itself should probably be updated).
zw963 commentedon Feb 7, 2025
Just for guys want table feature with markd, i workaround this use a trick.
e.g. i create a table like this:
the Char between the column is
……, it's a full width character, I can input it use keyboard^when enable Chinese input method(fcitx) in Linux, it will be replace with "\u{3000}", which is a Chinese full width Space, it can show a really space even in thetag.
following is the replacement code:
Following is the rendered result use markd
Not pefect, but useable, and write quickly too.
I am thinking, maybe we can use this trick to add a poor person's version of the table?
straight-shoota commentedon Feb 7, 2025
Most of the time you can use HTML tables as a workaround.
12 remaining items
nobodywasishere commentedon Mar 7, 2025
Go for it!
zw963 commentedon Mar 8, 2025
How about #57 ? should we add back to markd from markterm?
ralsina commentedon Mar 8, 2025
zw963 commentedon Mar 9, 2025
Hi, I am not use this feature, i mention it just because there is a open issue about it.
Consider talk about it at first with maintainer before you do it anyway.
ralsina commentedon Mar 9, 2025
Footnotes is more complicated than it seems but I am making progress (about 30% there I guess), probably will get it working in another week.
WIP PR here
zw963 commentedon Mar 9, 2025
Sorry, In fact, It may be useful for me when convert/fix the users (markdown)input in the comment into valid markdown, anyway, thanks
ralsina commentedon Mar 13, 2025
Initial very limited support for footnotes:
#78
I still need to do one or two PRs more, but didn't want to make this one bigger and harder to review.
ralsina commentedon Mar 13, 2025
Also, I think I already fixed all the "table edge cases" in a previous PR so it can be checked in the description.
ralsina commentedon Mar 18, 2025
I am stumped about how to make the footnote definition work as a container in #78
Surely I am missing the exact combination of Match::Container ans parser.advance or whatever.
This is needed because the content of the definition are basically to be parsed as part of the document, they may include blocks (code blocks, blockquotes, etc)
Sorry but at the end of my rope with that, so unless someone gives a hand it's probably not going to progress further.
ralsina commentedon Apr 14, 2025
Why not make a release? There are a lot of features implemented, there is no need to have full GFM support to do it.
nobodywasishere commentedon Apr 14, 2025
I've been meaning to take a look at your PR to see if I could help get it over the line, life stuff has gotten in the way recently though. Should have time soon.
ralsina commentedon Apr 14, 2025
@nobodywasishere no worries, I suspect tables is a much more interesting thing for users than footnotes, so a release without that PR should still be nice :-)
ralsina commentedon Feb 15, 2026
I have pushed changes in #78 that complete the footnote implementation, which was the only thing left for GFM support AFAIK?
nobodywasishere commentedon Feb 23, 2026
@ralsina What are the remaining pending gfm tests with that PR done?
ralsina commentedon Feb 23, 2026
There are 5 pending tests in total, 4 of them gfm related:
1 in gfm regressions:
2 in gfm-spec:
1 in gfm-extensions (which I think is not a bug but a spec ambiguity)