Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add standard outbound proxy support across Codex Pooler's HTTP, HTTPS, and WebSocket clients.
Deployments can now configure egress using the conventional lowercase environment variables:
http_proxyfor HTTP and WS targetshttps_proxyfor HTTPS and WSS targetsno_proxyfor destinations that should connect directlyThe uppercase
HTTP_PROXY,HTTPS_PROXY, andNO_PROXYvariants are also supported as fallbacks, with lowercase values taking precedence.Changes
http_proxyorhttps_proxyaccording to each request's target scheme.no_proxyentries for exact hosts, domain suffixes, IPv4 and IPv6 addresses, CIDR ranges, optional ports, and the*wildcard.Configuration
Only
http://proxy endpoints are accepted. HTTPS and WSS targets use an HTTP CONNECT tunnel through the configuredhttps_proxy.Leaving a lowercase variable empty explicitly disables its uppercase fallback.
Verification
no_proxymatching.git diff --checkpasses.sh -nand emits the three proxy variables correctly.The full ExUnit suite was not run in the implementation environment because Elixir/Mix was unavailable and the Docker daemon was inaccessible.