Harden star view visualization#89
Open
dkt01 wants to merge 1 commit into
Open
Conversation
…ved to a different host indefinitely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When jobs were initially scheduled on one runner and later move to another runner - such as when a timeout results in a job running on the host requesting the build - the star view could show the ring corresponding to that job forever. Navigating off of the star view and back to that view would clear the ring (#34), but it would not decrement the active job count.
Fix was two parts:
Verified by running icemon a full day with the changes. Previous version would accumulate "zombie" jobs steadily throughout the day.