Deployment zip filenames

[daniel-heppner-ibigroup]

Checklist

• Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
• Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
• The description lists all applicable issues this PR seeks to resolve
• The description lists any configuration setting(s) that differ from the default settings
• All tests and CI builds passing
• The description lists all relevant PRs included in this release (remove this if not merging to master)
• e2e tests are all passing (remove this if not merging to master)

Description

Datatools was not correctly using the configured GTFS feed source filename in the otp-runner manifest/bundle download, even though it was using the correct filenames in the web ui download. This fixes that

[binh-dam-ibigroup]

Is the "gtfs" substring guaranteed to be in getFeedSourceBundleFilename? I don't see comments regarding that.

[binh-dam-ibigroup]

For the fallback, copy the deleted comment about OTP2 requiring "gtfs" in the file name.
Also, is the presence of the "gtfs" substring guaranteed in getFeedSourceBundleFilename?

[daniel-heppner-ibigroup]

edit: misread your comment at first

I think that is not needed. The GTFS in the filename is used for autodiscovery of the zips, but it's not actually required. If the filename doesn't have gtfs in it, you must specify the filenames of the GTFS files in build-config, which is the goal here anyway since this allows us to specify feed IDs instead of using the non deterministic ones provided by OTP in the autodiscovery method.

[br648]

All good.