chore(deps): update gtfs-lib for CSV export fixes. - #662
Merged
Conversation
br648
approved these changes
Aug 11, 2026
br648
left a comment
br648
left a comment
Contributor
There was a problem hiding this comment.
Approving assuming the fix will come later?
miles-grant-ibigroup
approved these changes
Aug 12, 2026
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the update!
| assertRowCount(r1.fareRules, r2.fareRules, merged.fareRules, "Fare rules"); | ||
| assertRowCount(r1.frequencies, r2.frequencies, merged.frequencies, "Frequencies"); | ||
| assertRowCount(r1.locations, r2.locations, merged.locations, "Locations"); | ||
| // FIXME: Export locations of unsupported types when merging feeds. |
Contributor
There was a problem hiding this comment.
What change created this issue?
Contributor
Author
There was a problem hiding this comment.
r1.locations and r2.locations were returning 2 locations (the 2 others unknown in each were rejected). merged.locations returns 4. With ibi-group/gtfs-lib#28, r1.locations and r2.locations return 4 each, but only the 2 of known types are exported/written to the merged feed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
dev-flex.Description
This PR brings a fix from ibi-group/gtfs-lib#31.