[TMP] IBX-12043: Upgraded to Doctrine DBAL 4 - #35
Open
ViniTou wants to merge 2 commits into
Open
Conversation
ViniTou
changed the title
DBAL 4 removed the event system and the "platform" connection parameter, so the test kernel can no longer call setEventManager() on Ibexa's platforms or attach them via DoctrineBundle's platform_service.
Points ibexa/core, ibexa/doctrine-schema at their dbal-4-upgrade branches so this one can resolve before they are merged. Revert this commit once they are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Important
The
[TMP]commit pinsibexa/coreandibexa/doctrine-schemato theirdbal-4-upgradebranches. Revert it once those PRs merge.Description:
ibexa/test-corepinsdoctrine/dbalto 3.x, and every package's integration tests boot its kernel, so it has to move before they can.DBAL 4 removed the event system, so
setEventManager()no longer exists on Ibexa's database platforms. It also removed theplatformconnection parameter, which is what DoctrineBundle'splatform_servicesets — deprecated in doctrine-bundle 2.9 for exactly that reason. Neither failed loudly: the connection accepted the setting and silently returned the stock platform. Ibexa platforms are resolved explicitly where DDL is generated (seeDbPlatformFactoryin ibexa/core#800).For QA:
Test infrastructure only. Worth confirming a downstream package's integration tests still boot against MySQL, MariaDB and PostgreSQL.
Documentation:
N/A