Skip to content

Fixed inconsistent image storage prefix in test data - #34

Open
mikadamczyk wants to merge 2 commits into
6.0from
fixed-inconsistent-image-storage-prefix
Open

Fixed inconsistent image storage prefix in test data#34
mikadamczyk wants to merge 2 commits into
6.0from
fixed-inconsistent-image-storage-prefix

Conversation

@mikadamczyk

@mikadamczyk mikadamczyk commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
🎫 Issue N/A

Description:

ibexa_image_file holds two rows for the same content field (attribute ID 172, content 54) with different storage prefixes: version 1 uses var/storage, version 2 kept the demo-inherited var/ibexa_demo_site/storage. The latter does not match the default var_dir/storage_dir, so fully loading that content throws InvalidBinaryPrefixException — breaking any consumer whose test happens to load content 54 with its image field. This aligns the prefix (dirpath, url and filepath) and adds a lib test asserting every stored image path in the fixture uses the default prefix.

The stale row dates back to the initial Added test core commit (2023-05-18) and is present on all branches. No test in ibexa/core or ibexa/test-core asserts that path.

For QA:

Nothing to test manually. TestDataTest fails on both assertions before the data change and passes after it.

Documentation:

@mikadamczyk mikadamczyk self-assigned this Aug 5, 2026
@mikadamczyk
mikadamczyk requested a review from alongosz August 5, 2026 14:25
@mikadamczyk
mikadamczyk marked this pull request as ready for review August 6, 2026 09:43
@mikadamczyk
mikadamczyk requested a review from a team August 6, 2026 09:44

@Steveb-p Steveb-p left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the upgrade path for existing data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants