Fixed inconsistent image storage prefix in test data - #34
Open
mikadamczyk wants to merge 2 commits into
Open
Conversation
Steveb-p
reviewed
Aug 6, 2026
Steveb-p
left a comment
Collaborator
There was a problem hiding this comment.
What's the upgrade path for existing data?
bnowak
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
ibexa_image_fileholds two rows for the same content field (attribute ID 172, content 54) with different storage prefixes: version 1 usesvar/storage, version 2 kept the demo-inheritedvar/ibexa_demo_site/storage. The latter does not match the defaultvar_dir/storage_dir, so fully loading that content throwsInvalidBinaryPrefixException— breaking any consumer whose test happens to load content 54 with its image field. This aligns the prefix (dirpath,urlandfilepath) and adds alibtest asserting every stored image path in the fixture uses the default prefix.The stale row dates back to the initial
Added test corecommit (2023-05-18) and is present on all branches. No test inibexa/coreoribexa/test-coreasserts that path.For QA:
Nothing to test manually.
TestDataTestfails on both assertions before the data change and passes after it.Documentation: