Assert changed translations too, not just added or deleted - #32
Open
mikadamczyk wants to merge 2 commits into
Open
Assert changed translations too, not just added or deleted#32mikadamczyk wants to merge 2 commits into
mikadamczyk wants to merge 2 commits into
Conversation
Depends on jms-translation-bundle's new ChangeSet::getChangedMessages(). Assertion logic extracted into a static method so it's unit-testable without booting a kernel.
mikadamczyk
changed the title
mikadamczyk
marked this pull request as ready for review
August 5, 2026 14:29
konradoboza
approved these changes
Aug 5, 2026
bnowak
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
AbstractTranslationCaseonly failed when a message id was added or deleted. That left a gap: if someone edited the English text of an existing key in code, the id stayed the same, the changeset came back empty, and the test passed while the translation file on disk was already stale. Every package inheriting this case had that blind spot.It now also fails on changed messages, using the
getChangedMessages()API added in the related PR, and lists the offending ids with a hint to re-runtranslation:extract. The assertion moved into a static method so it can be unit-tested directly, without booting a kernel — the new test covers all four cases: empty changeset, added, deleted and changed.Kept as a draft because
getChangedMessages()is not merged or released yet, so CI here stays red until the related PR lands.For QA:
Nothing to test manually.
Documentation: