Removed title and descritpion extraction from HTML - #3341
Open
mnocon wants to merge 1 commit into
Open
Conversation
Preview of modified filesPreview of modified Markdown: |
mnocon
commented
Aug 5, 2026
| "commerce/shopping_list/shopping_list_design", | ||
| "commerce/shopping_list/shopping_list_api", | ||
| ("api/php_api/php_api_reference/namespaces/ibexa-contracts-shoppinglist.html", "PHP API Reference", "<code>Ibexa\Contracts\ShoppingList</code>"), | ||
| ("api/php_api/php_api_reference/namespaces/ibexa-contracts-shoppinglist.html", "PHP API Reference", "<code>Ibexa\\Contracts\\ShoppingList</code>"), |
Contributor
Author
There was a problem hiding this comment.
The \C was responsible for:
INFO - DeprecationWarning: invalid escape sequence '\C'
visible in the builds (https://github.com/ibexa/documentation-developer/actions/runs/30985847130/job/92240292415)
So it's not related to this PR, but small enoguh that IMHO can be included here.
Summary
|
mnocon
marked this pull request as ready for review
August 5, 2026 08:29
ibexa-workflow-automation-1
Bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
August 5, 2026 08:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target: 4.6, 5.0, 6.0, user doc
If you look at https://github.com/ibexa/documentation-developer/tags , you might see that a tag is created every day.
That's not supposed to happen, the tag should be created only when there's new content in the documentation.
The tags were created (incorrectly) because there was an actual difference in documentation content between them - turns out that our builds were not reproducible and relied on doc.ibexa.co access.
If requests to doc.ibexa.co succeeded: title and description were extracted, all good
If requests to doc.ibexa.co failed: they failed silently, title and description were set to empty
And we were not notified at all that it happens!
This has happened a couple of times when building the "Composer package" version of the doc (Cloudflare likes to respond with 429 for requests to doc.ibexa.co coming from GitHub Actions) and caused the content to fluctuate every day.
TBH it's possible that it was broken on the live site and we've never noticied.
And making requests whenever
mkdocs buildis run feels weird.This PR: