Fixed code samples after latest Rector release - #3338
Merged
Conversation
Preview of modified filesPreview of modified Markdown: |
Summary
|
mnocon
force-pushed
the
fix-code-samples
branch
from
August 4, 2026 08:23
6ef9805 to
761617e
Compare
mnocon
marked this pull request as ready for review
August 4, 2026 08:24
ibexa-workflow-automation-1
Bot
requested review from
adriendupuis,
dabrt and
julitafalcondusza
and removed request for
a team
August 4, 2026 08:25
adriendupuis
reviewed
Aug 4, 2026
Comment on lines
+28
to
+29
| SymfonySetList::SYMFONY_73, | ||
| SymfonySetList::SYMFONY_74, |
code_samples/ change report
|
adriendupuis
approved these changes
Aug 4, 2026
mnocon
added a commit
that referenced
this pull request
Aug 4, 2026
* Removed strictBooleans * Run SF 7.3, 7.4 rules * Removed SensioLabSetList * PHP-CS-Fixer
mnocon
added a commit
that referenced
this pull request
Aug 4, 2026
* Removed strictBooleans * Run SF 7.3, 7.4 rules * Removed SensioLabSetList * PHP-CS-Fixer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target: 4.6, 5.0, 6.0
For 4.6, only the change in the update notes should be cherry-picked
Should be possible to review this by commits.
strictBooleanshas been removed: [depre] Remove strict-booleans set deprecated since 2025-10 rectorphp/rector-src#8243I've used this opportunity to add the missing Symfony rules and run the refactoring.
CI failure in https://github.com/ibexa/documentation-developer/actions/runs/30838488540/job/91769459101?pr=3339 :
Another error: