Skip to content

Regenerate PHPStan - #794

Merged
Steveb-p merged 1 commit into
4.6from
fix-location-service-test-phpstan-baseline-drift
Jul 31, 2026
Merged

Regenerate PHPStan#794
Steveb-p merged 1 commit into
4.6from
fix-location-service-test-phpstan-baseline-drift

Conversation

@Steveb-p

@Steveb-p Steveb-p commented Jul 31, 2026

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-XXXXX

Description:

…nstanceOf ignores

The "already narrowed type" ignore counts for two assertInstanceOf(Location::class, ...)
patterns in this file (10 and 2) no longer match what PHPStan actually finds (9 and 1)
against currently resolved dependencies, since this project doesn't commit a composer.lock
and PHPStan's/its dependencies' analysis has drifted slightly over time. This currently
fails "composer run-script phpstan" (and therefore CI) on every branch based on 4.6.
Steveb-p added a commit that referenced this pull request Jul 31, 2026
…nstanceOf ignores

Unblocks this PR's CI. Pre-existing on 4.6 itself (unrelated to this PR's
changes) - see #794, which fixes it at the source; this commit
will become a no-op once that's merged and this branch is rebased on top.
@sonarqubecloud

Copy link
Copy Markdown

@Steveb-p Steveb-p changed the title Fix stale PHPStan baseline counts for LocationServiceTest.php Regenerate PHPStan Jul 31, 2026
@Steveb-p
Steveb-p requested a review from a team July 31, 2026 09:16
@ibexa-workflow-automation-1
ibexa-workflow-automation-1 Bot requested review from ViniTou, alongosz, barw4, bnowak, ciastektk, konradoboza, mikadamczyk, tbialcz and wiewiurdp and removed request for a team July 31, 2026 09:16
@Steveb-p
Steveb-p merged commit 03873a7 into 4.6 Jul 31, 2026
47 checks passed
@Steveb-p
Steveb-p deleted the fix-location-service-test-phpstan-baseline-drift branch July 31, 2026 09:59
@Steveb-p

Copy link
Copy Markdown
Contributor Author

Merged up into 5.0 in 9f28345.
Merged up into 6.0 in 05aeb04.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants