Skip to content

IBX-11747: Admin 405 responses trigger exception loop in prod mode - #1996

Open
Sztig wants to merge 2 commits into
4.6from
IBX-11747-admin-405-exception-loop-fix
Open

IBX-11747: Admin 405 responses trigger exception loop in prod mode#1996
Sztig wants to merge 2 commits into
4.6from
IBX-11747-admin-405-exception-loop-fix

Conversation

@Sztig

@Sztig Sztig commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-11747

Description:

I'm preventing the loping by only processing the error from the main request

        if (!$event->isMainRequest()) {
            return;
        }

I'm also handling the 405 code as a separate case with its own template

            case 405:
                $content = $this->twig->render('@ibexadesign/ui/error_page/405.html.twig');
                break;

This listener had no test coverage previously so I have added that as well, covered both the fix and the expected behavior outside this specific case.

For QA:

Documentation:

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants