IBX-12056: Applied dark mode to the preview header, kept popups light - #1995
Open
tischsoic wants to merge 1 commit into
Open
IBX-12056: Applied dark mode to the preview header, kept popups light#1995tischsoic wants to merge 1 commit into
tischsoic wants to merge 1 commit into
Conversation
Flagged the content preview header as a dark surface. Extra actions and popup menus assert `--ids-mode: light` so they keep their light styling when rendered inside a dark container, such as the Page Builder menu bar. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related PRs:
Description:
Two changes, both using the design system's new
--ids-modeflag.Content preview header — flagged as a dark surface, so the design system buttons it contains (the "Close" link-button and the device switcher) use their dark variants:
Extra actions and popup menus — these are white panels that are frequently rendered inside a dark container: the Page Builder menu bar hosts both the "Send to review" and "Publish later" extra-action panels in its own DOM subtree. Since
--ids-modeinherits, they would pick up the dark styling and render white buttons on their white background. Both now assert light mode explicitly:This is a general safeguard rather than a fix for one page — any future dark surface hosting these panels gets the correct behaviour for free. Popup menus that are moved to
document.bodyon init (the multilevel popup menu, the image editor's save menu) never inherited the flag in the first place, but the declaration keeps them correct if that ever changes.For QA:
Content preview — preview a content item; the dark header's "Close" button should be white text on a light-neutral border, and the device switcher icons white. Check hover and focus.
Popups on a dark surface — edit a Landing Page draft, then in the dark Page Builder menu bar open "Send to review" and the "Publish" chevron → "Publish later". Both panels must stay white with dark text and dark-on-white buttons.
Regression: extra-action panels and popup menus on ordinary light pages (e.g. Create buttons on list pages, context menus) must be unchanged.
Documentation: