Skip to content

IBX-12056: Applied dark mode to the preview header, kept popups light - #1995

Open
tischsoic wants to merge 1 commit into
6.0from
IBX-12056-scoped-dark-mode
Open

IBX-12056: Applied dark mode to the preview header, kept popups light#1995
tischsoic wants to merge 1 commit into
6.0from
IBX-12056-scoped-dark-mode

Conversation

@tischsoic

@tischsoic tischsoic commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
🎫 Issue IBX-12056

Related PRs:

Description:

Two changes, both using the design system's new --ids-mode flag.

Content preview header — flagged as a dark surface, so the design system buttons it contains (the "Close" link-button and the device switcher) use their dark variants:

.ibexa-preview-header {
    --ids-mode: dark;
    ...
}

Extra actions and popup menus — these are white panels that are frequently rendered inside a dark container: the Page Builder menu bar hosts both the "Send to review" and "Publish later" extra-action panels in its own DOM subtree. Since --ids-mode inherits, they would pick up the dark styling and render white buttons on their white background. Both now assert light mode explicitly:

.ibexa-extra-actions {
    --ids-mode: light;
    ...
}

.ibexa-popup-menu {
    --ids-mode: light;
    ...
}

This is a general safeguard rather than a fix for one page — any future dark surface hosting these panels gets the correct behaviour for free. Popup menus that are moved to document.body on init (the multilevel popup menu, the image editor's save menu) never inherited the flag in the first place, but the declaration keeps them correct if that ever changes.

For QA:

Content preview — preview a content item; the dark header's "Close" button should be white text on a light-neutral border, and the device switcher icons white. Check hover and focus.

Popups on a dark surface — edit a Landing Page draft, then in the dark Page Builder menu bar open "Send to review" and the "Publish" chevron → "Publish later". Both panels must stay white with dark text and dark-on-white buttons.

Regression: extra-action panels and popup menus on ordinary light pages (e.g. Create buttons on list pages, context menus) must be unchanged.

Documentation:

Flagged the content preview header as a dark surface. Extra actions and
popup menus assert `--ids-mode: light` so they keep their light styling
when rendered inside a dark container, such as the Page Builder menu bar.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants