Repository navigation
Accept named argument elements in a forced call - #250
Merged
Merged
Conversation
Gemma also writes a forced draw_image as <arg name="caption">…</arg> <arg name="prompt">…</arg>, and Qwen-style output uses <parameter=name> or <parameter name="name">. These were rejected, which sent the turn to the GPU2 fallback; they now give the same arguments as <caption>…</caption>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<arg name="caption">…</arg><arg name="prompt">…</arg></function></tool_call>.<arg name="…">,<parameter=…>and<parameter name="…">as well as from<name>. Every element must still name a parameter of the forced tool.Verification
cargo test -p openplotva-llm --lib: 203 passed; the new cases failed before the change.cargo clippy -p openplotva-llm --all-targets -- -D warnings.