Skip to content

test: remediate SDK baseline Help Center fixtures - #2

Draft
iPLAYCAFE-dev wants to merge 1 commit into
codex/sdk-submit-adapter-v1-sourcefrom
codex/sdk-submit-adapter-v1-provider-ci-remediation
Draft

test: remediate SDK baseline Help Center fixtures#2
iPLAYCAFE-dev wants to merge 1 commit into
codex/sdk-submit-adapter-v1-sourcefrom
codex/sdk-submit-adapter-v1-provider-ci-remediation

Conversation

@iPLAYCAFE-dev

Copy link
Copy Markdown
Owner

Scope

Test-only remediation for the pre-existing Help Center fixture/mock debt exposed by the SDK submit-adapter candidate.

DO NOT MERGE, RETARGET, MARK READY, PUBLISH, OR DEPLOY. This is a Draft review/evidence delta only.

Immutable provenance

  • Pinned Provider baseline commit: 305b8f06513e9a24e0b5e255ca1746472a8a0a89
  • Pinned Provider baseline tree: 57c4def3a63c35b62e4d7ae1a944066a34ec3a9e
  • Evidence candidate / PR widget: stage SDK submit adapter v1 evidence #1 commit: e66a110f604ed5f495086a6c55ac83e7bc79e48b
  • Evidence candidate / PR widget: stage SDK submit adapter v1 evidence #1 tree: db30d0c2a01f920d51350dbdb2f9d9bd364e2596
  • Remediation commit: e484c13f21db4f6beb72f0fff6734053fac742e3
  • Remediation tree: c37ccbca44274049a53b3664cd95f57679233791
  • Exact parent: e66a110f604ed5f495086a6c55ac83e7bc79e48b

The parent-to-head delta is one commit and modifies exactly four *.test.ts files. There are no runtime, SDK, auth implementation, fixture/contract, lockfile, workflow, manifest, deploy, or configuration changes.

Root cause and remediation

The same focused suite failed on both the pinned baseline and PR #1 candidate: 4 files, 48 failed / 59 passed. The candidate did not introduce those failing test blobs; the baseline runtime had gained fail-closed admin-only reads while its mocks and route expectations remained stale.

This delta adds deterministic empty query defaults, target fixtures, correct one-shot mock queues, the expected two-query category assertion, updated admin-role service signatures, and member-role fail-closed coverage for all nine article handler branches (includeAdminOnly: false).

Local verification

  • Focused remediation suite: 4 files, 116/116 tests passed.
  • Help Center suites: 8 files, 175/175 tests passed.
  • Baseline-to-head changed-test sweep: 38 files passed, 1 skipped; 602 passed, 1 skipped.
  • Full lint: exit 0; 0 errors, 23 warnings (one new nonblocking max-lines warning in the category service test file).
  • Widget build: passed.
  • Web/Nitro production build with SKIP_ENV_VALIDATION=true: passed.
  • Web typecheck after the required build order: passed.
  • git diff --check: passed.
  • Three independent read-only reviews passed: provenance, test integrity, and release safety; gitleaks found no leaks.

A fully green local all-suite claim is intentionally not made: this Windows host has no PostgreSQL service, so DB-backed tests cannot be a valid local gate. An earlier broad diagnostic recorded 12 ECONNREFUSED localhost:5432 failures plus two Asia/Bangkok timezone-sensitive changelog failures; those two passed under TZ=UTC. Exact GitHub CI with its pgvector/PostgreSQL 17 service and UTC environment is required.

Relationship to Provider PR #1

Provider PR #1 remains the immutable evidence-only baseline-to-candidate PR. It must stay Draft and must not be rewritten, retargeted, force-pushed, merged, or closed to make its historical failed run appear green. This Draft is based on codex/sdk-submit-adapter-v1-source, so it shows only the test-only remediation delta.

Remaining gates

  • Both exact-head GitHub CI jobs must complete successfully; no required job may be pending or skipped.
  • External upstream/live-evidence prerequisites remain unresolved, including InsForge PR #1766 and later release/canary gates.
  • No release successor, patch refresh, publish, deploy, or live mutation is authorized until Provider CI is terminal green and provenance is refreshed separately.

The ipc.21 baseline materialized fail-closed admin-only reads while legacy mocks and route expectations retained the previous call shape. Keep Provider runtime and the SDK adapter range unchanged while restoring deterministic CI evidence.
@iPLAYCAFE-dev

Copy link
Copy Markdown
Owner Author

Immutable CI evidence for the exact Draft head (recorded 2026-07-29; no PR retarget/rewrite):

  • Head commit: e484c13f21db4f6beb72f0fff6734053fac742e3
  • Head tree: c37ccbca44274049a53b3664cd95f57679233791
  • Exact parent / Draft base tip: e66a110f604ed5f495086a6c55ac83e7bc79e48b
  • CI run: 30442823021, attempt 1, pull_request, terminal success
  • check job 90545923829: success; install, lint, widget build, web build, and typecheck all ran and succeeded
  • test job 90545923698: success; PostgreSQL container initialization, frozen install, DB migration, and full test command all ran and succeeded
  • Full CI test summary: 536 files passed / 2 skipped; 5,825 tests passed / 11 skipped; zero failures
  • Local focused remediation: 116/116 passed; Help Center: 175/175 passed; baseline-to-head changed-test sweep: 602 passed / 1 skipped
  • Independent read-only reviews: provenance PASS, test-integrity PASS, release-safety/security-privacy PASS; gitleaks found no leaks

Scope remains test-only (four *.test.ts files). No runtime, SDK, contract/fixture, workflow, lockfile, deploy, publish, credential, DNS, live configuration, customer-facing, or analytics mutation occurred.

This evidence does not authorize merge, mark-ready, retarget, publish, deploy, or canary. Provider PR #1 remains untouched and evidence-only. External/live release prerequisites remain gated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant