test: remediate SDK baseline Help Center fixtures - #2
Draft
iPLAYCAFE-dev wants to merge 1 commit into
Draft
Conversation
The ipc.21 baseline materialized fail-closed admin-only reads while legacy mocks and route expectations retained the previous call shape. Keep Provider runtime and the SDK adapter range unchanged while restoring deterministic CI evidence.
Owner
Author
|
Immutable CI evidence for the exact Draft head (recorded 2026-07-29; no PR retarget/rewrite):
Scope remains test-only (four This evidence does not authorize merge, mark-ready, retarget, publish, deploy, or canary. Provider PR #1 remains untouched and evidence-only. External/live release prerequisites remain gated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Test-only remediation for the pre-existing Help Center fixture/mock debt exposed by the SDK submit-adapter candidate.
DO NOT MERGE, RETARGET, MARK READY, PUBLISH, OR DEPLOY. This is a Draft review/evidence delta only.
Immutable provenance
305b8f06513e9a24e0b5e255ca1746472a8a0a8957c4def3a63c35b62e4d7ae1a944066a34ec3a9ee66a110f604ed5f495086a6c55ac83e7bc79e48bdb30d0c2a01f920d51350dbdb2f9d9bd364e2596e484c13f21db4f6beb72f0fff6734053fac742e3c37ccbca44274049a53b3664cd95f57679233791e66a110f604ed5f495086a6c55ac83e7bc79e48bThe parent-to-head delta is one commit and modifies exactly four
*.test.tsfiles. There are no runtime, SDK, auth implementation, fixture/contract, lockfile, workflow, manifest, deploy, or configuration changes.Root cause and remediation
The same focused suite failed on both the pinned baseline and PR #1 candidate: 4 files, 48 failed / 59 passed. The candidate did not introduce those failing test blobs; the baseline runtime had gained fail-closed admin-only reads while its mocks and route expectations remained stale.
This delta adds deterministic empty query defaults, target fixtures, correct one-shot mock queues, the expected two-query category assertion, updated admin-role service signatures, and member-role fail-closed coverage for all nine article handler branches (
includeAdminOnly: false).Local verification
max-lineswarning in the category service test file).SKIP_ENV_VALIDATION=true: passed.git diff --check: passed.A fully green local all-suite claim is intentionally not made: this Windows host has no PostgreSQL service, so DB-backed tests cannot be a valid local gate. An earlier broad diagnostic recorded 12
ECONNREFUSED localhost:5432failures plus two Asia/Bangkok timezone-sensitive changelog failures; those two passed underTZ=UTC. Exact GitHub CI with its pgvector/PostgreSQL 17 service and UTC environment is required.Relationship to Provider PR #1
Provider PR #1 remains the immutable evidence-only baseline-to-candidate PR. It must stay Draft and must not be rewritten, retargeted, force-pushed, merged, or closed to make its historical failed run appear green. This Draft is based on
codex/sdk-submit-adapter-v1-source, so it shows only the test-only remediation delta.Remaining gates