fix(wire): retarget stale /vql/execute callers + fuzz target to VCL#148
Merged
Conversation
Completes the endpoint hard-rename (stage 1/5) for the callers it missed. After the rust core route /vql/execute -> /vcl/execute (no alias), these still pointed at the removed path: - ffi/zig GraphQL gateway: full VQL->VCL sweep — outbound call to the rust core (graphql.zig), the gateway's own inbound /vcl/execute route (router.zig), and its GraphQL surface (executeVql -> executeVcl, VqlResult -> VclResult). The API-surface rename is a deliberate breaking change, consistent with the hard-rename applied everywhere else. - examples/load-sample-data.sh, examples/smoke-test.sh: curl endpoint only. - .clusterfuzzlite/build.sh: fuzz_vql_parser -> fuzz_vcl_parser (both fuzz/Cargo.toml and rust-core/fuzz/Cargo.toml already use fuzz_vcl_parser). Deferred (different rename axis): examples/vql-queries/ dir, *.vql fixtures, and "VQL" comments/seed-data prose -> tracked with the *.vql fixture-naming stage. No Zig toolchain here; verified statically (length-preserving token swaps, zero residual vql in scope, no dangling executeVql/VqlResult references). https://claude.ai/code/session_01W9Voe3JceP66Bna9FT4jME
🔍 Hypatia Security ScanFindings: 137 issues detected
View findings[
{
"reason": "Issue in scorecard-enforcer.yml",
"type": "scorecard_publish_with_run_step",
"file": "scorecard-enforcer.yml",
"action": "split_scorecard_publish_job",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in instant-sync.yml",
"type": "secret_action_without_presence_gate",
"file": "instant-sync.yml",
"action": "peter-evans/repository-dispatch",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in codeql.yml",
"type": "codeql_missing_actions_language",
"file": "codeql.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (1 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/Provenance.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (2 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/PlannerSemantic.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (1 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/Planner.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (6 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/Drift.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (1 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/WAL.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (2 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/Normalizer.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "getExn on external data -- use pattern matching (1 occurrences, CWE-754)",
"type": "getexn_on_external",
"file": "/home/runner/work/verisimdb/verisimdb/src/registry/Registry.res",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire-rename leftovers
Stage
1/5hard-renamed the rust core route/vql/execute→/vcl/executewith no alias, but a few callers/refs were missed and have been broken since. This sweeps them up.ffi/zig/src/graphql.zigVQL→VCL: outbound{rust}/vcl/execute,executeVql→executeVcl,VqlResult→VclResult,vql_val→vcl_val, messages/vql/executeffi/zig/src/router.zig/vcl/execute+ commentffi/zig/README.adoc/api/v1/vcl/execute,executeVcl,VclResult)examples/load-sample-data.sh,examples/smoke-test.shcurlendpoint →/vcl/execute.clusterfuzzlite/build.shfuzz_vql_parser→fuzz_vcl_parserfuzz/Cargo.tomlandrust-core/fuzz/Cargo.tomlalready name the targetfuzz_vcl_parserNote: breaking change to the ffi/zig GraphQL API
The gateway's own mutation
executeVql→executeVclandVqlResult→VclResult. This is intentional and consistent with the no-alias hard-rename applied across the rust core and SDKs. Verified no other repo file referencesexecuteVql/VqlResult.Deferred (different rename axis — not wire contract)
examples/vql-queries/dir, the*.vqlfixture files, and "VQL" comments /seed.jsonsample-data prose are tracked with the*.vqlfixture-naming stage (theMustfile/REUSE.toml*.vqlglobs still expect that extension). The example scripts still readvql-queries/*.vql— left intact so they keep working until that stage lands.Verification
No Zig toolchain in this environment/CI, so validated statically: length-preserving token swaps, zero residual
vqlin the touchedffi/zig+ scripts +build.sh, and no danglingexecuteVql/VqlResultanywhere.🤖 Draft. Independent of #147 (ReScript); both branch off
main.Generated by Claude Code