Skip to content

fix(wire): retarget stale /vql/execute callers + fuzz target to VCL#148

Merged
hyperpolymath merged 1 commit into
mainfrom
vcl/wire-rename-leftovers
Jun 14, 2026
Merged

fix(wire): retarget stale /vql/execute callers + fuzz target to VCL#148
hyperpolymath merged 1 commit into
mainfrom
vcl/wire-rename-leftovers

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Wire-rename leftovers

Stage 1/5 hard-renamed the rust core route /vql/execute/vcl/execute with no alias, but a few callers/refs were missed and have been broken since. This sweeps them up.

File Change Why
ffi/zig/src/graphql.zig full VQL→VCL: outbound {rust}/vcl/execute, executeVqlexecuteVcl, VqlResultVclResult, vql_valvcl_val, messages gateway was POSTing to the removed /vql/execute
ffi/zig/src/router.zig inbound route /vcl/execute + comment gateway's own surface
ffi/zig/README.adoc GraphQL API docs (/api/v1/vcl/execute, executeVcl, VclResult) match the code
examples/load-sample-data.sh, examples/smoke-test.sh curl endpoint → /vcl/execute scripts hit the removed path
.clusterfuzzlite/build.sh fuzz_vql_parserfuzz_vcl_parser both fuzz/Cargo.toml and rust-core/fuzz/Cargo.toml already name the target fuzz_vcl_parser

Note: breaking change to the ffi/zig GraphQL API

The gateway's own mutation executeVqlexecuteVcl and VqlResultVclResult. This is intentional and consistent with the no-alias hard-rename applied across the rust core and SDKs. Verified no other repo file references executeVql/VqlResult.

Deferred (different rename axis — not wire contract)

examples/vql-queries/ dir, the *.vql fixture files, and "VQL" comments / seed.json sample-data prose are tracked with the *.vql fixture-naming stage (the Mustfile/REUSE.toml *.vql globs still expect that extension). The example scripts still read vql-queries/*.vql — left intact so they keep working until that stage lands.

Verification

No Zig toolchain in this environment/CI, so validated statically: length-preserving token swaps, zero residual vql in the touched ffi/zig + scripts + build.sh, and no dangling executeVql/VqlResult anywhere.


🤖 Draft. Independent of #147 (ReScript); both branch off main.


Generated by Claude Code

Completes the endpoint hard-rename (stage 1/5) for the callers it missed.
After the rust core route /vql/execute -> /vcl/execute (no alias), these
still pointed at the removed path:

- ffi/zig GraphQL gateway: full VQL->VCL sweep — outbound call to the rust
  core (graphql.zig), the gateway's own inbound /vcl/execute route
  (router.zig), and its GraphQL surface (executeVql -> executeVcl,
  VqlResult -> VclResult). The API-surface rename is a deliberate breaking
  change, consistent with the hard-rename applied everywhere else.
- examples/load-sample-data.sh, examples/smoke-test.sh: curl endpoint only.
- .clusterfuzzlite/build.sh: fuzz_vql_parser -> fuzz_vcl_parser (both
  fuzz/Cargo.toml and rust-core/fuzz/Cargo.toml already use fuzz_vcl_parser).

Deferred (different rename axis): examples/vql-queries/ dir, *.vql fixtures,
and "VQL" comments/seed-data prose -> tracked with the *.vql fixture-naming
stage.

No Zig toolchain here; verified statically (length-preserving token swaps,
zero residual vql in scope, no dangling executeVql/VqlResult references).

https://claude.ai/code/session_01W9Voe3JceP66Bna9FT4jME
@github-actions

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 137 issues detected

Severity Count
🔴 Critical 17
🟠 High 54
🟡 Medium 66

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "Issue in scorecard-enforcer.yml",
    "type": "scorecard_publish_with_run_step",
    "file": "scorecard-enforcer.yml",
    "action": "split_scorecard_publish_job",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in instant-sync.yml",
    "type": "secret_action_without_presence_gate",
    "file": "instant-sync.yml",
    "action": "peter-evans/repository-dispatch",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in codeql.yml",
    "type": "codeql_missing_actions_language",
    "file": "codeql.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "User-defined Coq axiom -- not verified by kernel (1 occurrences, CWE-704)",
    "type": "coq_axiom",
    "file": "/home/runner/work/verisimdb/verisimdb/formal/Provenance.v",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "medium"
  },
  {
    "reason": "User-defined Coq axiom -- not verified by kernel (2 occurrences, CWE-704)",
    "type": "coq_axiom",
    "file": "/home/runner/work/verisimdb/verisimdb/formal/PlannerSemantic.v",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "medium"
  },
  {
    "reason": "User-defined Coq axiom -- not verified by kernel (1 occurrences, CWE-704)",
    "type": "coq_axiom",
    "file": "/home/runner/work/verisimdb/verisimdb/formal/Planner.v",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "medium"
  },
  {
    "reason": "User-defined Coq axiom -- not verified by kernel (6 occurrences, CWE-704)",
    "type": "coq_axiom",
    "file": "/home/runner/work/verisimdb/verisimdb/formal/Drift.v",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "medium"
  },
  {
    "reason": "User-defined Coq axiom -- not verified by kernel (1 occurrences, CWE-704)",
    "type": "coq_axiom",
    "file": "/home/runner/work/verisimdb/verisimdb/formal/WAL.v",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "medium"
  },
  {
    "reason": "User-defined Coq axiom -- not verified by kernel (2 occurrences, CWE-704)",
    "type": "coq_axiom",
    "file": "/home/runner/work/verisimdb/verisimdb/formal/Normalizer.v",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "medium"
  },
  {
    "reason": "getExn on external data -- use pattern matching (1 occurrences, CWE-754)",
    "type": "getexn_on_external",
    "file": "/home/runner/work/verisimdb/verisimdb/src/registry/Registry.res",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "critical"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@hyperpolymath hyperpolymath marked this pull request as ready for review June 14, 2026 03:02
@hyperpolymath hyperpolymath merged commit c36f39b into main Jun 14, 2026
41 checks passed
@hyperpolymath hyperpolymath deleted the vcl/wire-rename-leftovers branch June 14, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants