refactor(rust): VCL rename stage B (1/5) — rust-core server + openapi (#84)#144
Merged
Conversation
First sub-stage of the Stage B code rename (#84). Per maintainer decision this is a hard rename including the public endpoint (no back-compat alias). Renamed (git mv + identifiers, 26 files): - verisim-api/src/vql.rs -> vcl.rs; route POST /vql/execute -> /vcl/execute; handler vql_execute_handler -> vcl_execute_handler; `pub mod vql` -> `pub mod vcl` - verisim-planner/src/vql_bridge.rs -> vcl_bridge.rs (AST types VqlAst/VqlQuery/... -> Vcl*); `pub mod vql_bridge` -> vcl_bridge - verisim-repl/src/vql_fmt.rs -> vcl_fmt.rs; REPL binary "vql" -> "vcl"; client POSTs /vcl/execute; .vqlrc -> .vclrc - both fuzz targets fuzz_vql_parser -> fuzz_vcl_parser (file + [[bin]] name + path), importing verisim_api::vcl::tokenize - connectors/shared/openapi/verisim-api-v1.yaml: /api/v1/vcl/execute - tests/integration_test.rs Follow-ups (tracked under #84, intentionally out of this PR): - Client SDKs still call /api/v1/vql/execute (Elixir/Rust/Zig/Julia/ ReScript/playground) -> clients sub-stage. CI unaffected: clients compile against their own string; no live integration test in unit CI. - Elixir-internal contracts (type:vql_query tag, vql_dt_active, the vql-bridge/ JS dir + @parser_script_path) -> Elixir follow-up. Verified locally (cargo cannot build offline here -- oxigraph et al. need network, so the real compile runs on CI): grep-to-zero leaves no vql/VQL/Vql token in rust-core/fuzz/openapi/integration; no other workspace crate imports the renamed modules/types; symmetric 418/418 diff (equal-length token swaps, no structural change). Refs #84. https://claude.ai/code/session_01W9Voe3JceP66Bna9FT4jME
🔍 Hypatia Security ScanFindings: 134 issues detected
View findings[
{
"reason": "Issue in scorecard-enforcer.yml",
"type": "scorecard_publish_with_run_step",
"file": "scorecard-enforcer.yml",
"action": "split_scorecard_publish_job",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in instant-sync.yml",
"type": "secret_action_without_presence_gate",
"file": "instant-sync.yml",
"action": "peter-evans/repository-dispatch",
"rule_module": "workflow_audit",
"severity": "high"
},
{
"reason": "Issue in codeql.yml",
"type": "codeql_missing_actions_language",
"file": "codeql.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (1 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/Provenance.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (2 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/PlannerSemantic.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (1 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/Planner.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (6 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/Drift.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (1 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/WAL.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "User-defined Coq axiom -- not verified by kernel (2 occurrences, CWE-704)",
"type": "coq_axiom",
"file": "/home/runner/work/verisimdb/verisimdb/formal/Normalizer.v",
"action": "flag",
"rule_module": "code_safety",
"severity": "medium"
},
{
"reason": "getExn on external data -- use pattern matching (1 occurrences, CWE-754)",
"type": "getexn_on_external",
"file": "/home/runner/work/verisimdb/verisimdb/src/registry/Registry.res",
"action": "flag",
"rule_module": "code_safety",
"severity": "critical"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
hyperpolymath
pushed a commit
that referenced
this pull request
Jun 14, 2026
Second sub-stage of #84. Updates the four non-ReScript client SDKs to the renamed wire contract from PR #144 (server route /api/v1/vcl/execute). - connectors/clients/rust/src/vql.rs -> vcl.rs (mod vcl, execute_vcl, Vcl{Request,Response,Result,ParseError,ExecutionError}) - connectors/clients/zig/src/vql.zig -> vcl.zig - connectors/clients/julia/src/vql.jl -> vcl.jl - connectors/clients/elixir/lib/verisim_client/vcl.ex + types.ex - all four now POST /api/v1/vcl/execute Verified: grep-to-zero leaves no vql/VQL/Vql token in the four client trees; endpoint updated in every SDK; symmetric 99/99 diff. Rust client compiles on CI (cargo); Zig/Julia/Elixir renames are mechanical (string + symbol). Refs #84. https://claude.ai/code/session_01W9Voe3JceP66Bna9FT4jME
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage B (1/5) — server core, hard rename of the VQL→VCL wire contract
First sub-stage of the Stage B code rename (#84). Per maintainer decision: hard rename including the public endpoint (no back-compat alias), and ReScript is in-scope for Stage B (later sub-stage). This PR is the server source-of-truth:
rust-core/+ openapi.Renamed (
git mv+ identifiers — 26 files, symmetric 418/418)verisim-api/src/vql.rs→vcl.rs; routePOST /vql/execute→/vcl/execute;vql_execute_handler→vcl_execute_handler;pub mod vql→vclverisim-planner/src/vql_bridge.rs→vcl_bridge.rs; AST typesVqlAst/VqlQuery/… →Vcl*verisim-repl/src/vql_fmt.rs→vcl_fmt.rs; binaryvql→vcl; client POSTs/vcl/execute;.vqlrc→.vclrcfuzz_vql_parsertargets →fuzz_vcl_parser(file +[[bin]]name + path), importingverisim_api::vcl::tokenize/api/v1/vcl/execute;tests/integration_test.rsCoupling / planned follow-ups (out of this PR, under #84)
/api/v1/vcl/execute+ symbolssrc/vql/parser, playground,VeriSimVql.res(quarantine lifted)type:vql_querytag,vql_dt_active,vql-bridge/JS dir +@parser_script_path, bench filesClients still call
/api/v1/vql/executeuntil sub-stage 2 — CI is unaffected (they compile against their own path string; no live integration test in unit CI), runtime round-trip is restored when 2–4 land.Verification
cargocan't build offline here (oxigraph et al. need network), so the real compile runs on this PR's CI (cargo build/test/clippy/cargo doc/fuzz-compile). Locally confirmed:vql/VQL/Vqltoken left inrust-core/fuzz/openapi/integrationVql*→Vcl*PascalCase pass, no structural changeRefs #84.
Generated by Claude Code