Skip to content

fix(ci): the invisible-character gate never matched anything #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyperpolymath wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(ci): the invisible-character gate never matched anything #57

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be6e8f4
fix(ci): the invisible-character gate never matched anything
hyperpolymath Aug 27, 2026
cce5532
fix(ci): make invisible-character PCRE locale-independent
hyperpolymath Aug 28, 2026
edbdf22
Update .github/workflows/dogfood-gate.yml
hyperpolymath Aug 28, 2026
6c3c2a4
Merge branch 'main' into fix/empty-linter-pattern-never-matched
hyperpolymath Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/dogfood-gate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
# Checks for: zero-width spaces, zero-width joiners, BOM, soft hyphens,
# non-breaking spaces, null bytes, and other invisible Unicode in source files.
set +e
PATTERNS='\xc2\xa0|\xe2\x80\x8b|\xe2\x80\x8c|\xe2\x80\x8d|\xef\xbb\xbf|\xc2\xad|\xe2\x80\x8e|\xe2\x80\x8f|\xe2\x80\xaa|\xe2\x80\xab|\xe2\x80\xac|\xe2\x80\xad|\xe2\x80\xae|\x00'
PATTERNS='(*UTF)[\x00-\x08\x0B\x0C\x0E-\x1F\x{a0}\x{ad}\x{200b}-\x{200f}\x{202a}-\x{202f}\x{2060}\x{2066}-\x{2069}\x{feff}]'

@codacy-production codacy-production Bot Aug 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

The (*UTF) prefix forces strict UTF-8 validation. If a file contains invalid UTF-8 sequences, grep will error out and skip that file. Because stderr is redirected to /dev/null on line 133, these failures are silent, meaning invisible characters in malformed files will go undetected. Consider removing the stderr redirection or adding a mechanism to alert when files fail validation.

find "$GITHUB_WORKSPACE" \
-not -path '*/.git/*' -not -path '*/node_modules/*' \
-not -path '*/.deno/*' -not -path '*/target/*' \
Expand All @@ -130,7 +130,7 @@ jobs:
-o -name '*.yml' -o -name '*.yaml' -o -name '*.md' -o -name '*.adoc' \
-o -name '*.idr' -o -name '*.zig' -o -name '*.v' -o -name '*.jl' \
-o -name '*.gleam' -o -name '*.hs' -o -name '*.ml' -o -name '*.sh' \) \
-exec grep -Prl "$PATTERNS" {} \; > /tmp/empty-lint-results.txt 2>/dev/null
-exec grep -aPl "$PATTERNS" {} + > /tmp/empty-lint-results.txt
EL_EXIT=$?

@codacy-production codacy-production Bot Aug 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

The captured exit_code is currently unused in the summary step. If the scanner fails to run (e.g., due to a regex syntax error), the job will report success because the results file will be empty. Update the 'Write summary' step to check if the exit_code is non-zero and report a scanner failure if so.

set -e

Expand Down
Loading