Repository navigation
fix(evidence): derive reader path candidates by component, as the writer does - #74
Merged
Merged
Conversation
…ter does The writer keys a file with `Path::strip_prefix`, which compares components. The reader removed a literal string prefix. For root `repo` and file `repo/./a.php` the writer keyed `a.php` and the reader derived `./a.php`, so `validate-report` rejected a report this build had written: `semantic fingerprint mismatch` as 0.5.0 and `record/finding mismatch` as its frozen 0.4.0 projection. Repeated separators, a trailing `.`, the root spelling `repo/.` and a file named twice had the same defect. `path_for_style` now compares components for each reading (the root, then every name; empty components and every `.` except a leading one are dropped; `..` is kept) and returns the producer's spelling from the next component to the end of the last one. `relative_path`, the semantic fingerprint, the single-reading rule in the validator and both schemas are unchanged, so current and frozen keys are unchanged. The lexical `./a.php` is not an extra candidate. Controls: exact POSIX and Windows readings for each case, compared with the native writer on the host that runs them; an exhaustive comparison of the native writer with the host reading over every short path (132,253 pairs on Linux); and a contract test that drives this build's own `scan_files` report through `pons validate-report` as 0.5.0 and 0.4.0, with relative `repo` labels in both separator styles, and rejects the lexical key as record path, fingerprint input, both, and in a frozen report. Validation on x86_64 Linux, rustc 1.97.1: fmt and all-target Clippy with warnings denied passed. As root, 266 tests passed and the three POSIX permission fixtures failed, as they do at 612145d (263 passed, 3 failed); the pons-core unit binary as uid 1000 passed 146 of 146. tests/e2e.sh passed 46 of 46 on the release build. No Windows host ran these tests locally; hosted Linux and Windows checks must complete on the pull request. Drive, UNC and verbatim prefixes remain ordinary names in the reader. Creusot/Pearlite and Verus remain OPEN/not run. Addresses the open review finding on #73 and contributes to hyperpolymath/echo-types#362. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6 Signed-off-by: Claude <noreply@anthropic.com>
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6 Signed-off-by: Claude <noreply@anthropic.com>
hyperpolymath
marked this pull request as ready for review
November 10, 2026 14:40
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
hyperpolymath
enabled auto-merge (squash)
November 10, 2026 14:40
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
hyperpolymath
added a commit
to hyperpolymath/echo-types
that referenced
this pull request
Nov 10, 2026
This change records the evidence that was read on 10 November 2026 for #362. It is documentation only. No Agda source changes and no proof claim changes. It does not close #362. ## What changes - New file `docs/audit/2026-11-10-scanner-follow-up-update.adoc`. It is a dated update to the 7 November receipt. It names each earlier statement that it supersedes. - `docs/audit/2026-11-07-scanner-follow-up.adoc`: one section is added at the end with a link to the update. The 145 earlier lines are unchanged. - `docs/AUDIT.adoc`: index entries for the 7 November receipt and for the update. ## What the update records | Item | Result | |---|---| | PANIC attribution | Pull requests 268 to 271 are attributed one by one, from a fresh clone. `f2a6a70` is on `main`. | | PONS 73 | Merged as `612145d` with the tested tree `28d2068a`. This supersedes "must complete its final review and merge". | | Path defect | Reproduced at `612145d`. Repaired on `main` by hyperpolymath/pons-asinorum#74, merged as `d4adad0`. Hosted Linux and Windows jobs passed on the pull-request head and on `main`. | | Review threads | One disposition for each of the 9 threads on PONS 72 and 73. One thread on 73 is still marked unresolved; I did not change it. | | CodeQL | Run 42400643452, attempt 2, read back as success. The deletion of the obsolete category stays owner-reported. This supersedes "approval is pending". | | Echo rescan | With PONS `d4adad0`: the JSX file gives 0 findings and 0 skips. The whole input gives 3 files, 8 heuristic warnings and 23 skips, `partial`. | ## States that stay open or not verified - No review of pons-asinorum 74 was obtained. The CodeRabbit check reads cancelled because the pull request closed. Codex reported its usage limit. - The CodeRabbit review of the original audit (360) is not obtained. - Two PONS workflows (`main-estate-audit.yml`, `creusot-gate.yml`) ended with no jobs on PONS `main`. They call the suite by its former name `hyperpolymath/cicd-suite`. A run with no jobs is not a pass. See hyperpolymath/proven-cicd-and-workflows#68. - Code-scanning analyses and alerts, the app installation inventory and the `panic-attack` pull-request records were not accessible to this session. - Agda is outside PONS coverage. SMTP is dormant. Creusot with Pearlite contracts and Verus are OPEN, not run. No independent human approval is claimed. ## Verification - `sh scripts/verify.sh` exited 0 with the pinned Agda 2.7.0.1 (`scripts/setup-agda.sh`): the 4 static guards passed and 27 of 27 proof checks passed. This run was on the documentation change before its last wording edits. The proof sources are identical. - The 4 static guards were run again on the final tree and passed: `scripts/kernel-guard.sh`, `tools/check-guardrails.sh proofs/agda`, `scripts/check-experimental-aggregate.sh`, `scripts/check-agda-invocations.sh`. Refs #362 --- _Generated by [Claude Code](https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6)_ --------- Signed-off-by: Claude <noreply@anthropic.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This change closes the open Codex finding on #73 (discussion_r4503157325). It contributes to hyperpolymath/echo-types#362. It does not close that issue.
Defect
The writer keys a file with
Path::strip_prefix, which compares components. The reader removed a literal string prefix. For rootrepoand filerepo/./a.php, the writer keyeda.phpand the reader derived./a.php.Reproduced at
612145d805c6ec519d60fc65e406e9c091462848on x86_64 Linux with rustc 1.97.1 (8bab26f4f, therust-toolchain.tomlpin):Engine::scan_fileswrote record pathsample.phpfor the file<root>/./sample.php.pons validate-reportrejected that report:semantic fingerprint mismatchas 0.5.0, andrecord/finding mismatchas its frozen 0.4.0 projection.repo/./sub/a.php,repo//a.php,repo/a.php/., the root spellingrepo/., the absolute form/tmp/repo/./a.php, and one file named twice (filerepo/./a.php, rootrepo/a.php).repo//,./a.phpbelow., and spelling after the first kept component (repo/sub/./a.phpissub/./a.phpon both sides).repo\.\a.phpdoes not reproduce on a POSIX writer. The Windows reading in the reader had the defect. A Windows writer was not run locally.Change
path_for_styleincrates/pons-core/src/evidence.rsnow compares components for each reading: the root, then every name. Empty components and every.except a leading one are dropped...is kept. The result is the spelling of the producer from the next component to the end of the last one, asComponents::as_pathreturns it.Not changed:
relative_path,corroborate::semantic_fingerprint,report/validate.rs(the rule that requires one reading for the record path and the fingerprint), and both schemas. Current and frozen keys are therefore unchanged. The lexical./a.phpis not an additional candidate.Controls
component_equivalent_spellings_have_the_writer_key: exact POSIX and Windows readings for each case. The native writer is compared with the reading of the host that runs the test.the_host_reading_is_the_native_writer_on_every_short_path: the native writer against the host reading for every path of up to 6 characters over a name,.and the host separators, against every root of up to 4 characters. This is 132,253 pairs on Linux. The Windows job runs the same comparison with both separators.a_component_equivalent_file_spelling_validates_with_the_writer_key(CLI contract): thescan_filesreport of this build goes throughpons validate-reportas 0.5.0 and as 0.4.0, with its absolute root and with the relative labelrepoin both separator styles. The test rejects./sample.phpas a record path, as a fingerprint input, as both together, and in a frozen report.ambiguous_legacy_paths_require_one_consistent_record_and_fingerprint,a_forged_corroboration_key_is_rejectedanda_relative_windows_report_validates_on_every_reader_host.Local validation (x86_64 Linux, rustc 1.97.1)
cargo fmt --checkRUSTFLAGS="-D warnings" cargo clippy --workspace --all-targets -- -D warningscargo test --workspace --no-fail-fastas root612145das rootpons-coreunit binary as uid 1000cargo build --releasethenbash tests/e2e.shPONS_BIN=target/release/pons bash tests/doc_drift.shThe 3 failures are the POSIX permission fixtures. They refuse to run as root (
fixture is readable despite mode 000 — running as root?). They are not related to this change.Three deliberate reader mutations (keep interior
., drop the parent rule, keep trailing components) each failed both new unit tests. The mutations are not committed.Echo rescan with the release build of
428e81b(clean) at echo-typesb6c8b97b40c1cf6489f0c93d2dd6183c30e4d0e4:pons scan docs/echo-types/prototypes/warrant_debugger_prototype.jsx --no-speculative --fail-on error --fail-on-skips --require-language javascript --format json: 1 file analysed, 0 findings, 0 skips,complete-within-policy, exit 0.pons scan . --no-speculative --fail-on error --format json: 3 files analysed, 8 heuristic warnings, 23 explicit skips,partial, exit 0.pons validate-report.Limits
612145d. A drive-letter case difference, a bareC:root and.below a\\?\root are not modelled, and no test here covers them.Generated by Claude Code