Skip to content

Preserve portable report paths and Unicode JavaScript boundaries - #72

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/echo362-portable-review
Nov 7, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/echo362-portable-review

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Follow-up to the outstanding review on #71, which merged while these findings were being addressed. Preserve POSIX filename boundaries in single-file evidence, distinguish an in-root colon filename from a Windows drive path that was not stripped from the root, and match ECMAScript whitespace independently of the C locale at in/instanceof boundaries. AST assertions cover comment continuations before calls, members and addition, including Unicode line terminators. The external-scanner receipt advances to 0.25.0+jsx-keywords.3.

Validation: 258 Windows workspace test executions, all-target Clippy with warnings denied, eight parser regression tests, and all 116 unchanged upstream grammar parses passed. Hosted checks and final app reviews must finish before merge. Creusot/Pearlite and Verus remain OPEN/not run. Contributes to hyperpolymath/echo-types#362.

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9e34e71e-43af-435c-b892-586256863c97
Commits

Reviewing files that changed from the base of the PR and between 20fbcc7 and f8becf2.

Files selected for processing: 8

  • crates/pons-core/src/evidence.rs
  • crates/pons-core/src/lang.rs
  • crates/pons-core/src/report/validate.rs
  • crates/pons-core/tests/parser_adversarial.rs
  • docs/PLAN.adoc
  • docs/echo-362-verification.adoc
  • vendor/tree-sitter-javascript/PATCHES.adoc
  • vendor/tree-sitter-javascript/src/scanner.c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

sonarqubecloud Bot commented Nov 7, 2026

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 7, 2026 16:36
@hyperpolymath
hyperpolymath merged commit 0112b2a into main Nov 7, 2026
24 checks passed
@hyperpolymath
hyperpolymath deleted the fix/echo362-portable-review branch November 7, 2026 16:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-07T16:42:45.854466Z f8becf2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f8becf2948

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/pons-core/src/evidence.rs Resolved
Comment thread crates/pons-core/src/evidence.rs Resolved
Comment thread crates/pons-core/src/evidence.rs Resolved
hyperpolymath added a commit that referenced this pull request Nov 7, 2026
Relative source paths can be ambiguous across producer platforms. Normal
CLI scans (including forced grammars) and Engine::scan now use absolute
roots. Native writers retain the historical path semantics. Readers
enumerate the applicable POSIX and Windows interpretations of legacy
relative paths and require the record path and semantic fingerprint to
agree on the same interpretation; they do not infer a platform from
their own host or claim to recover missing producer-platform metadata.

Add full report controls for relative Windows directories, historical
POSIX scan_files paths and Windows single-file paths, including frozen
0.4.0 projections and rejection of mixed record/fingerprint
interpretations. CLI controls assert the exact file, forced-file-parent
and directory roots; a Unix-only test exercises a real colon/backslash
filename. Update ScanReport::root and Appendix G to describe absolute
roots and their checkout details.

The original 0.4.0 writer behaviour was checked against 6a20ca7 and
84f58f9. These selected the parent before replacing backslashes; a later
temporary early-normalization bug is not the frozen contract.

Validation: 261 Windows workspace test executions and all-target Clippy
passed. After extending frozen-envelope coverage, all eight CLI contract
tests passed. The first hosted revision passed Linux and Windows; the
latest revision must complete hosted checks and final app review before
merge. No grammar/generated-parser change. Creusot/Pearlite and Verus
remain OPEN/not run. Addresses the remaining review on #72 and
contributes to hyperpolymath/echo-types#362.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants