Repository navigation
Preserve portable report paths and Unicode JavaScript boundaries - #72
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 16 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f8becf2948
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Relative source paths can be ambiguous across producer platforms. Normal CLI scans (including forced grammars) and Engine::scan now use absolute roots. Native writers retain the historical path semantics. Readers enumerate the applicable POSIX and Windows interpretations of legacy relative paths and require the record path and semantic fingerprint to agree on the same interpretation; they do not infer a platform from their own host or claim to recover missing producer-platform metadata. Add full report controls for relative Windows directories, historical POSIX scan_files paths and Windows single-file paths, including frozen 0.4.0 projections and rejection of mixed record/fingerprint interpretations. CLI controls assert the exact file, forced-file-parent and directory roots; a Unix-only test exercises a real colon/backslash filename. Update ScanReport::root and Appendix G to describe absolute roots and their checkout details. The original 0.4.0 writer behaviour was checked against 6a20ca7 and 84f58f9. These selected the parent before replacing backslashes; a later temporary early-normalization bug is not the frozen contract. Validation: 261 Windows workspace test executions and all-target Clippy passed. After extending frozen-envelope coverage, all eight CLI contract tests passed. The first hosted revision passed Linux and Windows; the latest revision must complete hosted checks and final app review before merge. No grammar/generated-parser change. Creusot/Pearlite and Verus remain OPEN/not run. Addresses the remaining review on #72 and contributes to hyperpolymath/echo-types#362.



Follow-up to the outstanding review on #71, which merged while these findings were being addressed. Preserve POSIX filename boundaries in single-file evidence, distinguish an in-root colon filename from a Windows drive path that was not stripped from the root, and match ECMAScript whitespace independently of the C locale at
in/instanceofboundaries. AST assertions cover comment continuations before calls, members and addition, including Unicode line terminators. The external-scanner receipt advances to0.25.0+jsx-keywords.3.Validation: 258 Windows workspace test executions, all-target Clippy with warnings denied, eight parser regression tests, and all 116 unchanged upstream grammar parses passed. Hosted checks and final app reviews must finish before merge. Creusot/Pearlite and Verus remain OPEN/not run. Contributes to hyperpolymath/echo-types#362.