Skip to content

Reject unrecognized finding severities before baseline ranking - #188

Merged
hyperpolymath merged 2 commits into
audit/language-safety-20260907from
coderabbit/validate-severity-before-ranking/13de6bd8
Sep 15, 2026
Merged

hyperpolymath merged 2 commits into
audit/language-safety-20260907from
coderabbit/validate-severity-before-ranking/13de6bd8

Conversation

@coderabbitai

@coderabbitai coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Validate every finding severity against the supported critical, high, medium, low, info, and advisory values before applying the baseline. Report unique invalid values and exit with an error so unknown severities cannot silently receive an incorrect rank.

Validation was not run.

View coding task

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

Review Change StackReview Change Stack

Important

Review skipped

This PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Essentials

Run ID: c8b444f7-3f06-4b21-a5fd-85d293b60e23

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Essentials

Run ID: f35b4ace-fc0b-41bd-86ef-a7d4fe95fc9d

📥 Commits

Reviewing files that changed from the base of the PR and between 3be1801 and 8ca70b3.

📒 Files selected for processing (1)
  • scripts/apply-baseline.sh

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📜 Recent review details
🔇 Additional comments (1)
scripts/apply-baseline.sh (1)

76-86: LGTM!


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Baseline processing now validates all finding severity values before continuing.
    • Unrecognised severity values are reported individually, and processing exits with an error status.

Walkthrough

The baseline script now validates all finding severity values before processing. It reports each unrecognised value and exits with code 2 when invalid values exist.

Changes

Baseline Validation

Layer / File(s) Summary
Finding severity validation
scripts/apply-baseline.sh
The script checks severity values before baseline processing, lists unrecognised values, and exits with code 2 when validation fails.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: hyperpolymath

Merge Risk: ⚪ Minimal · up to 8ca70

The script now rejects unsupported severity values before baseline processing, with no remaining merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: rejecting unrecognised finding severities before baseline ranking.
Description check ✅ Passed The description directly explains the severity validation, error reporting, and prevention of incorrect baseline ranking. The note that validation was not run does not make the description unrelated.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

Comment @coderabbitai help to get the list of available commands.

…e-severity-before-ranking/13de6bd8

Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
@hyperpolymath
hyperpolymath merged commit 3ceeaa3 into audit/language-safety-20260907 Sep 15, 2026
6 checks passed
@hyperpolymath
hyperpolymath deleted the coderabbit/validate-severity-before-ranking/13de6bd8 branch September 15, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant