Skip to content

fix: invalid // comment headers in YAML/Justfile#30

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/practical-newton-9eFe2
Jun 14, 2026
Merged

fix: invalid // comment headers in YAML/Justfile#30
hyperpolymath merged 1 commit into
mainfrom
claude/practical-newton-9eFe2

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Problem

The estate-standardization script wrote the Owner: header line using C-style // comment syntax into files that use # comments. // is not a valid comment in YAML or in just, so it breaks those parsers.

Fix

Changed the leading // Owner: to # Owner: in the four affected files only:

  • .gitlab-ci.yml (line 2) — YAML
  • .pre-commit-config.yaml (line 2) — YAML
  • Justfile (line 2) — just
  • container/.gatekeeper.yaml (line 2) — YAML

Each was // Owner: Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk> and is now # Owner: ....

Left as-is (correct)

.adoc files (e.g. README.adoc) keep // — that is a valid line comment in AsciiDoc, so they were intentionally not touched. No .md or .rs files were modified.

Verification

git grep -nI '^// Owner:' -- '*.yml' '*.yaml' Justfile '**/Justfile' returns no matches after the fix.

https://claude.ai/code/session_017TXizM5c1Yd9HWf7Y15YH2


Generated by Claude Code

The estate-standardization "Owner:" header was written with C-style // in
files that use # comments (.gitlab-ci.yml, .pre-commit-config.yaml, Justfile,
container/.gatekeeper.yaml), which is invalid and breaks those parsers.
Changed `// Owner:` -> `# Owner:`. (.adoc files left as-is: // is valid there.)

https://claude.ai/code/session_017TXizM5c1Yd9HWf7Y15YH2
@github-actions

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 41 issues detected

Severity Count
🔴 Critical 4
🟠 High 11
🟡 Medium 26

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "codeql.yml lists `language: javascript-typescript` but the repo has no source files in any CodeQL-scannable language. The analyze job will exit 'no source files' on every run. Switch the matrix to `actions` (which scans workflow files — every repo has those).",
    "type": "codeql_language_matrix_mismatch",
    "file": "codeql.yml",
    "action": "switch_codeql_matrix_to_actions",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in scorecard-enforcer.yml",
    "type": "scorecard_publish_with_run_step",
    "file": "scorecard-enforcer.yml",
    "action": "split_scorecard_publish_job",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in instant-sync.yml",
    "type": "secret_action_without_presence_gate",
    "file": "instant-sync.yml",
    "action": "peter-evans/repository-dispatch",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in scorecard.yml",
    "type": "scorecard_wrapper_missing_job_permissions",
    "file": "scorecard.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in codeql.yml",
    "type": "codeql_missing_actions_language",
    "file": "codeql.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Download-and-execute pattern (curl|wget pipe to shell) -- verify integrity before execution (3 occurrences, CWE-494)",
    "type": "shell_download_then_run",
    "file": "/home/runner/work/krl/krl/setup.sh",
    "action": "flag",
    "rule_module": "code_safety",
    "severity": "high"
  },
  {
    "line": 24,
    "reason": "Secret found: Generic API key",
    "type": "secret_detected",
    "file": "/home/runner/work/krl/krl/.envrc",
    "action": "revoke_rotate_and_purge",
    "rule_module": "security_errors",
    "severity": "critical"
  },
  {
    "reason": "Nominal-only SAST in krl: codeql.yml language matrix contains no language present in the repo and lacks `actions`, so CodeQL records zero results on every commit. Remediation: set the CodeQL matrix to `language: actions`.",
    "type": "StaticAnalysis",
    "file": "/home/runner/work/krl/krl",
    "action": "auto_fix",
    "rule_module": "scorecard",
    "severity": "medium",
    "remediation": "Add CodeQL or equivalent SAST workflow.",
    "scorecard_check": "SAST"
  },
  {
    "reason": "1 workflow(s) with tag-pinned (not SHA-pinned) actions in krl",
    "type": "DependencyPinning",
    "file": "/home/runner/work/krl/krl",
    "action": "auto_fix",
    "rule_module": "scorecard",
    "severity": "medium",
    "remediation": "Pin GitHub Actions and Docker base images by SHA hash.",
    "scorecard_check": "Pinned-Dependencies"
  },
  {
    "reason": "Repository has 3 non-main remote branch(es). Policy: single main branch only.",
    "type": "GS007",
    "file": ".",
    "action": "delete_remote_branches",
    "rule_module": "git_state",
    "severity": "medium"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@hyperpolymath hyperpolymath marked this pull request as ready for review June 14, 2026 10:51
@hyperpolymath hyperpolymath merged commit e42eeaf into main Jun 14, 2026
12 of 14 checks passed
@hyperpolymath hyperpolymath deleted the claude/practical-newton-9eFe2 branch June 14, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants