Clarify invisible-character scanner cleanup comment - #765
Open
coderabbitai[bot] wants to merge 4 commits into
Open
Clarify invisible-character scanner cleanup comment#765coderabbitai[bot] wants to merge 4 commits into
coderabbitai[bot] wants to merge 4 commits into
Conversation
Replace the character-mode PCRE escapes (\xc2\xa0 asks for the two characters U+00C2 U+00A0, never present in any file) with the canonical byte-safe two-tier scanner from rsr-template-repo (rsr#49): scripts/check-invisible-characters.sh matches UTF-8 byte sequences under LC_ALL=C, so typographic invisibles (NBSP, soft hyphen, zero-width/bidi, BOM) warn while C0/NUL corruption blocks, and scanner failure refuses a partial pass instead of going green. tests/invisible-characters-test.sh proves the detector against fixtures that MUST trip it — including a leading BOM — and the workflow runs that proof before every scan. Also fixes the seven NBSP-bearing docs the old gate never saw. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Base automatically changed from
fix/invisible-gate-canonical-scanner
to
main
September 9, 2026 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies that the scanner cleanup function removes its temporary NUL-delimited enumeration file on exit. This diverges from the task title: no PR function docstrings were added. Validation was not run because the change is comment-only.
View coding task