Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #557

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e7ff1dfb-5089-482e-9363-ec8b9c10b8e0

📥 Commits

Reviewing files that changed from the base of the PR and between e78aa60 and 27473d1.

📒 Files selected for processing (2)
  • .github/workflows/governance.yml
  • .github/workflows/mirror.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (32)
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: governance / Licence consistency
  • GitHub Check: scan / shell-secrets
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: scan / rust-secrets
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: scan / gitleaks
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: build · test · clippy (shared-context)
  • GitHub Check: Build Pages artifact
  • GitHub Check: Identify PRs passed CICD
  • GitHub Check: Repo Integrity Guard
  • GitHub Check: build · test · clippy (robot-repo-automaton)
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: build · test · clippy (rhodibot)
  • GitHub Check: build · test · clippy (dashboard)
  • GitHub Check: E2E tests
  • GitHub Check: GSBot build, tests and dependency security
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Validate A2ML manifests
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate K9 contracts
🔇 Additional comments (2)
.github/workflows/governance.yml (1)

39-42: LGTM!

.github/workflows/mirror.yml (1)

20-23: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Corrected workflow permission configuration for governance and mirroring jobs.
    • Confirmed required read and security-event permissions are applied consistently.

Walkthrough

The workflows now define permissions at the correct job level. The permission values remain actions: read, contents: read, and security-events: write.

Changes

Workflow permissions

Layer / File(s) Summary
Job-level permission declarations
.github/workflows/governance.yml, .github/workflows/mirror.yml
The permissions blocks now use the correct job-level indentation. The permission values are unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the CI permissions indentation fix and the invalid YAML issue.
Description check ✅ Passed The description directly explains the invalid YAML, the indentation correction, the preserved permissions, and the affected workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow gate
Permissions sit in the proper state
Read actions, contents too
Security events can write anew
The jobs now run as YAML dictates

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit c19a86e into main Sep 21, 2026
31 of 35 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant